Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable A11yTreeIsConsistent with higher timeout #29367

Merged
merged 4 commits into from
Nov 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions shell/platform/embedder/tests/embedder_a11y_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ namespace testing {

using Embedder11yTest = testing::EmbedderTest;

// TODO(52372): De-flake and re-enable.
TEST_F(Embedder11yTest, DISABLED_A11yTreeIsConsistent) {
TEST_F(Embedder11yTest, A11yTreeIsConsistent) {
auto& context = GetEmbedderContext(EmbedderTestContextType::kOpenGLContext);

fml::AutoResetWaitableEvent latch;
Expand Down
3 changes: 2 additions & 1 deletion testing/fuchsia/test_suites.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
package: txt_tests-0.far
- test_command: run-test-suite fuchsia-pkg://fuchsia.com/ui_tests#meta/ui_tests.cm
package: ui_tests-0.far
- test_command: run-test-suite fuchsia-pkg://fuchsia.com/embedder_tests#meta/embedder_tests.cm
# TODO(fxb/87493): re-enable when this doesn't crash.
- test_command: run-test-suite fuchsia-pkg://fuchsia.com/embedder_tests#meta/embedder_tests.cm -- --gtest_filter=-Embedder11yTest.A11yTreeIsConsistent
package: embedder_tests-0.far
- test_command: run-test-suite fuchsia-pkg://fuchsia.com/dart_utils_tests#meta/dart_utils_tests.cm
package: dart_utils_tests-0.far
4 changes: 2 additions & 2 deletions testing/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ std::optional<fml::TimeDelta> GetTestTimeoutFromArgs(int argc, char** argv) {

std::string timeout_seconds;
if (!command_line.GetOptionValue("timeout", &timeout_seconds)) {
// No timeout specified. Default to 30s.
return fml::TimeDelta::FromSeconds(30u);
// No timeout specified. Default to 120s.
return fml::TimeDelta::FromSeconds(120u);
}

const auto seconds = std::stoi(timeout_seconds);
Expand Down