Reland Display Features support (Foldable and Cutout) #29447

andreidiaconu · 2021-11-01T17:38:31Z

Relands Display Features support (Foldable and Cutout) #24756
Reverts Revert "Display Features support (Foldable and Cutout)" #28447
Updates WindowManager android library from beta01 to beta03 (publishing a new version of the android dependencies bundle is needed)

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…le_support

andreidiaconu · 2021-11-01T21:27:23Z

@blasten Could you please update the android_embedding_bundle in cipd? I updated from 1.0.0-beta01 to 1.0.0-beta03 and the bundle created for #24756 is outdated now.

blasten · 2021-11-03T17:31:26Z

@andreidiaconu Please use last_updated:2021-11-03T10:29:50-0700.

blasten · 2021-11-03T18:05:42Z

Is it ready to land if all checks are green?

andreidiaconu · 2021-11-03T18:12:53Z

Yes, although gradle lockfiles might need to be updated, and there are also a few gradle files still using 30, both of which should be fixed by flutter/flutter#89511 - I am ready to update it once this gets merged.

blasten · 2021-11-03T18:16:43Z

ok. We might need to manually roll the engine upon merging this PR. cc @zanderso

zanderso · 2021-11-03T18:50:10Z

@blasten Is there logic that could be added to the autoroller script to update the lockfiles?

blasten · 2021-11-03T19:01:40Z

potentially. does the autoroller script run in a LUCI bot, or some environment that can run Dart code?

zanderso · 2021-11-03T19:33:23Z

@rami-a may know.

blasten

LGTM

…r/engine#29447)

This reverts commit 3364409.

…" (#29574) This reverts commit 3364409.

…r/engine#29447)

…flutter#29447)" (flutter#29574)" This reverts commit df686d2.

* 422b15a Roll Skia from d9d9e21b311c to a8d38078a4f3 (1 revision) (flutter/engine#29521) * afe1c98 Roll Fuchsia Mac SDK from SfdmlzXiU... to nkHhPcy3q... (flutter/engine#29522) * b7f4651 Roll Fuchsia Linux SDK from 5-RB9TzQH... to m90mMA37b... (flutter/engine#29523) * 15d5a23 [Web] Fix BMP encoder (flutter/engine#29448) * 3f55aec Fix FlutterPresentInfo struct_size doc string (flutter/engine#29524) * b991af9 Roll Skia from a8d38078a4f3 to 7368c6d00b7c (5 revisions) (flutter/engine#29525) * 93666e2 Fix isolate_configuration typo (flutter/engine#29318) * 91033b9 Roll Skia from 7368c6d00b7c to a5030e9090e8 (3 revisions) (flutter/engine#29527) * c2090c2 [iOS] Make sure spawnee's isGpuDisabled is set correctly when FlutterEngine spawn (flutter/engine#29361) * e071f1d Roll Skia from a5030e9090e8 to 37afdbc22e89 (4 revisions) (flutter/engine#29528) * ca1710a Roll Skia from 37afdbc22e89 to a05d3029ac65 (4 revisions) (flutter/engine#29532) * 3364409 Reland Display Features support (Foldable and Cutout) (flutter/engine#29447) * 4684d23 [fuchsia] Add more logging for error cases. (flutter/engine#29397) * 5cf7c39 Remove D3D9 fallback path (flutter/engine#29533) * 98d31de [raster_cache] Increment access_count on Touch (flutter/engine#29529) * cc6fc4a Re-enable A11yTreeIsConsistent with higher timeout (flutter/engine#29367) * fb20916 Roll Skia from a05d3029ac65 to 37da672b14b7 (1 revision) (flutter/engine#29534) * d229ec8 use SkMatrix.invert() instead of MatrixDecomposition to validate cache matrices (flutter/engine#29530) * a92aebb Roll Clang Linux from 5N9a1nYj5... to UtjvZhwws... (flutter/engine#29535) * 47dab8a Roll Dart SDK from 3b11f88c96a5 to f38618d5d0c0 (7 revisions) (flutter/engine#29537) * 83ccad7 FragmentProgram constructed asynchronously (flutter/engine#29513) * 2078baf Roll Fuchsia Linux SDK from m90mMA37b... to Ci-Vji1rx... (flutter/engine#29546) * 6bf8093 Roll Fuchsia Mac SDK from nkHhPcy3q... to emi7COLIo... (flutter/engine#29547) * 290d179 Roll Skia from 37da672b14b7 to cf8daf79e710 (9 revisions) (flutter/engine#29548) * 197ca59 [iOS] Fixes press key message leaks (flutter/engine#29354) * 986b8d8 Roll Skia from cf8daf79e710 to ae67f07a58a2 (1 revision) (flutter/engine#29549) * 11010f0 Roll Skia from ae67f07a58a2 to 17616469ddf8 (1 revision) (flutter/engine#29551) * dadc7b2 Roll Skia from 17616469ddf8 to 4322c7fec7e4 (3 revisions) (flutter/engine#29552) * ed66091 don't build flutter SDK artifacts for armv7 (flutter/engine#28016) * 484cc5c Roll Dart SDK from f38618d5d0c0 to 05febe0a7860 (5 revisions) (flutter/engine#29539) * 387563a Roll Skia from 4322c7fec7e4 to 1800d410df16 (1 revision) (flutter/engine#29553) * 05ceba2 Roll Skia from 1800d410df16 to 725705f6630b (1 revision) (flutter/engine#29555) * 2b142ef Roll Dart SDK from 05febe0a7860 to 38e7078fa2b7 (5 revisions) (flutter/engine#29556) * 29da91f Roll Fuchsia Linux SDK from Ci-Vji1rx... to kHXT3xnTG... (flutter/engine#29557) * da02a4b Roll Fuchsia Mac SDK from emi7COLIo... to 6BYh8qaYo... (flutter/engine#29558) * 71fb575 Roll Skia from 725705f6630b to deb9386be146 (3 revisions) (flutter/engine#29559) * c5f572a [Linux keyboard] Fix logical keys of up events are not regularized (flutter/engine#29550) * 988ea43 Roll Dart SDK from 38e7078fa2b7 to d464cd3f2dc8 (5 revisions) (flutter/engine#29561) * fdee74d Trace calls to Canvas::saveLayer (flutter/engine#29444) * 953f718 ios test script checks for `ios_test_flutter` artifacts (flutter/engine#29554) * 145d890 Roll Skia from deb9386be146 to 37bef2d300e4 (6 revisions) (flutter/engine#29563) * cc9b174 Fix race condition introduced by background platform channels (flutter/engine#29377) * 79b5e3c Roll Dart SDK from d464cd3f2dc8 to 996ef242a2c9 (1 revision) (flutter/engine#29564) * 3eb6e15 fuchsia: Enable integration tests (flutter/engine#29565) * ffa8b25 Roll Skia from 37bef2d300e4 to 2417872a9993 (1 revision) (flutter/engine#29567) * 9af2de9 Roll Dart SDK from 996ef242a2c9 to 5ccf755b37a4 (1 revision) (flutter/engine#29568) * 16d6d18 Roll Fuchsia Linux SDK from kHXT3xnTG... to uP2kJIngK... (flutter/engine#29569) * 321bc56 Roll Fuchsia Mac SDK from 6BYh8qaYo... to W9UXc2Fwx... (flutter/engine#29570) * f0a8d4e Roll Dart SDK from 5ccf755b37a4 to f6a43e5eb71d (1 revision) (flutter/engine#29571) * 0be0303 Hide a11y elements when resigning active (flutter/engine#29566) * 9a3195a Roll Fuchsia Linux SDK from uP2kJIngK... to aD3d4Kqmy... (flutter/engine#29572) * b3cbee5 Roll Fuchsia Mac SDK from W9UXc2Fwx... to rIpW1050J... (flutter/engine#29573) * df686d2 Revert "Reland Display Features support (Foldable and Cutout) (#29447)" (flutter/engine#29574) * e812731 Revert dart to 38e7078fa2b7 (flutter/engine#29575) * 049074e Roll Skia from 2417872a9993 to cd7220e7686c (2 revisions) (flutter/engine#29577) * e6a51a4 Roll Fuchsia Mac SDK from rIpW1050J... to TOmxgL3av... (flutter/engine#29578) * 8f272d9 Roll Fuchsia Linux SDK from aD3d4Kqmy... to ZniYyCw7U... (flutter/engine#29579) * 469d6f1 Revert "[Web] Fix BMP encoder (#29448)" (flutter/engine#29580)

* 422b15a Roll Skia from d9d9e21b311c to a8d38078a4f3 (1 revision) (flutter/engine#29521) * afe1c98 Roll Fuchsia Mac SDK from SfdmlzXiU... to nkHhPcy3q... (flutter/engine#29522) * b7f4651 Roll Fuchsia Linux SDK from 5-RB9TzQH... to m90mMA37b... (flutter/engine#29523) * 15d5a23 [Web] Fix BMP encoder (flutter/engine#29448) * 3f55aec Fix FlutterPresentInfo struct_size doc string (flutter/engine#29524) * b991af9 Roll Skia from a8d38078a4f3 to 7368c6d00b7c (5 revisions) (flutter/engine#29525) * 93666e2 Fix isolate_configuration typo (flutter/engine#29318) * 91033b9 Roll Skia from 7368c6d00b7c to a5030e9090e8 (3 revisions) (flutter/engine#29527) * c2090c2 [iOS] Make sure spawnee's isGpuDisabled is set correctly when FlutterEngine spawn (flutter/engine#29361) * e071f1d Roll Skia from a5030e9090e8 to 37afdbc22e89 (4 revisions) (flutter/engine#29528) * ca1710a Roll Skia from 37afdbc22e89 to a05d3029ac65 (4 revisions) (flutter/engine#29532) * 3364409 Reland Display Features support (Foldable and Cutout) (flutter/engine#29447) * 4684d23 [fuchsia] Add more logging for error cases. (flutter/engine#29397) * 5cf7c39 Remove D3D9 fallback path (flutter/engine#29533) * 98d31de [raster_cache] Increment access_count on Touch (flutter/engine#29529) * cc6fc4a Re-enable A11yTreeIsConsistent with higher timeout (flutter/engine#29367) * fb20916 Roll Skia from a05d3029ac65 to 37da672b14b7 (1 revision) (flutter/engine#29534) * d229ec8 use SkMatrix.invert() instead of MatrixDecomposition to validate cache matrices (flutter/engine#29530) * a92aebb Roll Clang Linux from 5N9a1nYj5... to UtjvZhwws... (flutter/engine#29535) * 47dab8a Roll Dart SDK from 3b11f88c96a5 to f38618d5d0c0 (7 revisions) (flutter/engine#29537) * 83ccad7 FragmentProgram constructed asynchronously (flutter/engine#29513) * 2078baf Roll Fuchsia Linux SDK from m90mMA37b... to Ci-Vji1rx... (flutter/engine#29546) * 6bf8093 Roll Fuchsia Mac SDK from nkHhPcy3q... to emi7COLIo... (flutter/engine#29547) * 290d179 Roll Skia from 37da672b14b7 to cf8daf79e710 (9 revisions) (flutter/engine#29548) * 197ca59 [iOS] Fixes press key message leaks (flutter/engine#29354) * 986b8d8 Roll Skia from cf8daf79e710 to ae67f07a58a2 (1 revision) (flutter/engine#29549) * 11010f0 Roll Skia from ae67f07a58a2 to 17616469ddf8 (1 revision) (flutter/engine#29551) * dadc7b2 Roll Skia from 17616469ddf8 to 4322c7fec7e4 (3 revisions) (flutter/engine#29552) * ed66091 don't build flutter SDK artifacts for armv7 (flutter/engine#28016) * 484cc5c Roll Dart SDK from f38618d5d0c0 to 05febe0a7860 (5 revisions) (flutter/engine#29539) * 387563a Roll Skia from 4322c7fec7e4 to 1800d410df16 (1 revision) (flutter/engine#29553) * 05ceba2 Roll Skia from 1800d410df16 to 725705f6630b (1 revision) (flutter/engine#29555) * 2b142ef Roll Dart SDK from 05febe0a7860 to 38e7078fa2b7 (5 revisions) (flutter/engine#29556) * 29da91f Roll Fuchsia Linux SDK from Ci-Vji1rx... to kHXT3xnTG... (flutter/engine#29557) * da02a4b Roll Fuchsia Mac SDK from emi7COLIo... to 6BYh8qaYo... (flutter/engine#29558) * 71fb575 Roll Skia from 725705f6630b to deb9386be146 (3 revisions) (flutter/engine#29559) * c5f572a [Linux keyboard] Fix logical keys of up events are not regularized (flutter/engine#29550) * 988ea43 Roll Dart SDK from 38e7078fa2b7 to d464cd3f2dc8 (5 revisions) (flutter/engine#29561) * fdee74d Trace calls to Canvas::saveLayer (flutter/engine#29444) * 953f718 ios test script checks for `ios_test_flutter` artifacts (flutter/engine#29554) * 145d890 Roll Skia from deb9386be146 to 37bef2d300e4 (6 revisions) (flutter/engine#29563) * cc9b174 Fix race condition introduced by background platform channels (flutter/engine#29377) * 79b5e3c Roll Dart SDK from d464cd3f2dc8 to 996ef242a2c9 (1 revision) (flutter/engine#29564) * 3eb6e15 fuchsia: Enable integration tests (flutter/engine#29565) * ffa8b25 Roll Skia from 37bef2d300e4 to 2417872a9993 (1 revision) (flutter/engine#29567) * 9af2de9 Roll Dart SDK from 996ef242a2c9 to 5ccf755b37a4 (1 revision) (flutter/engine#29568) * 16d6d18 Roll Fuchsia Linux SDK from kHXT3xnTG... to uP2kJIngK... (flutter/engine#29569) * 321bc56 Roll Fuchsia Mac SDK from 6BYh8qaYo... to W9UXc2Fwx... (flutter/engine#29570) * f0a8d4e Roll Dart SDK from 5ccf755b37a4 to f6a43e5eb71d (1 revision) (flutter/engine#29571) * 0be0303 Hide a11y elements when resigning active (flutter/engine#29566) * 9a3195a Roll Fuchsia Linux SDK from uP2kJIngK... to aD3d4Kqmy... (flutter/engine#29572) * b3cbee5 Roll Fuchsia Mac SDK from W9UXc2Fwx... to rIpW1050J... (flutter/engine#29573) * df686d2 Revert "Reland Display Features support (Foldable and Cutout) (flutter#29447)" (flutter/engine#29574) * e812731 Revert dart to 38e7078fa2b7 (flutter/engine#29575) * 049074e Roll Skia from 2417872a9993 to cd7220e7686c (2 revisions) (flutter/engine#29577) * e6a51a4 Roll Fuchsia Mac SDK from rIpW1050J... to TOmxgL3av... (flutter/engine#29578) * 8f272d9 Roll Fuchsia Linux SDK from aD3d4Kqmy... to ZniYyCw7U... (flutter/engine#29579) * 469d6f1 Revert "[Web] Fix BMP encoder (flutter#29448)" (flutter/engine#29580)

Revert Revert "Display Features support (Foldable and Cutout)" 2e111ed

ab99014

flutter-dashboard bot added platform-android platform-fuchsia platform-web Code specifically for the web engine labels Nov 1, 2021

google-cla bot added the cla: yes label Nov 1, 2021

andreidiaconu mentioned this pull request Nov 1, 2021

Reland engine display features flutter/flutter#89511

Merged

8 tasks

andreidiaconu added 3 commits November 1, 2021 23:16

Update window to 1.0.0-beta03

28333d2

Merge branch 'master' of github.com:flutter/engine into reland_foldab…

dd06312

…le_support

Format FlutterViewTest.java

35f070d

andreidiaconu changed the title ~~[Draft] Reland Display Features support (Foldable and Cutout)~~ Reland Display Features support (Foldable and Cutout) Nov 1, 2021

andreidiaconu marked this pull request as ready for review November 1, 2021 21:24

Update android embedding bundle dependency in DEPS

c604098

blasten approved these changes Nov 3, 2021

View reviewed changes

blasten merged commit 3364409 into flutter:master Nov 4, 2021

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 2078baf24633 (22 revisions) flutter/flutter#93099

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

f9b1671

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 290d1792cedb (24 revisions) flutter/flutter#93101

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

1a2097f

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 197ca594c5ca (25 revisions) flutter/flutter#93105

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

acd727e

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 986b8d8ff32f (26 revisions) flutter/flutter#93108

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

482f533

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 986b8d8ff32f (26 revisions) flutter/flutter#93118

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

19b243b

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 11010f002879 (27 revisions) flutter/flutter#93132

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

6835a91

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to dadc7b217d22 (28 revisions) flutter/flutter#93142

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

701c4e8

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to ed66091d93b1 (29 revisions) flutter/flutter#93147

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

9d5d173

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 387563aecb9f (31 revisions) flutter/flutter#93149

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

3e32855

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 2b142ef2c686 (33 revisions) flutter/flutter#93154

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

6dca251

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to 71fb575952f1 (36 revisions) flutter/flutter#93159

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

66a6c02

…r/engine#29447)

engine-flutter-autoroll mentioned this pull request Nov 5, 2021

Roll Engine from 5140e30cec13 to c5f572ac70b9 (37 revisions) flutter/flutter#93162

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

a6d0f78

…r/engine#29447)

zanderso added a commit that referenced this pull request Nov 7, 2021

Revert "Reland Display Features support (Foldable and Cutout) (#29447)"

4420493

This reverts commit 3364409.

zanderso mentioned this pull request Nov 7, 2021

Revert "Reland Display Features support (Foldable and Cutout)" #29574

Merged

zanderso added a commit that referenced this pull request Nov 7, 2021

Revert "Reland Display Features support (Foldable and Cutout) (#29447)…

df686d2

…" (#29574) This reverts commit 3364409.

engine-flutter-autoroll mentioned this pull request Nov 7, 2021

Roll Engine from 5140e30cec13 to 8f272d98c92f (57 revisions) flutter/flutter#93216

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

29852ef

…r/engine#29447)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2021

3364409 Reland Display Features support (Foldable and Cutout) (flutte…

4973141

…r/engine#29447)

andreidiaconu added a commit to andreidiaconu/engine that referenced this pull request Nov 8, 2021

Revert "Revert "Reland Display Features support (Foldable and Cutout) (…

26f568c

…flutter#29447)" (flutter#29574)" This reverts commit df686d2.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland Display Features support (Foldable and Cutout) #29447

Reland Display Features support (Foldable and Cutout) #29447

Uh oh!

andreidiaconu commented Nov 1, 2021 •

edited

Loading

Uh oh!

andreidiaconu commented Nov 1, 2021 •

edited

Loading

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

andreidiaconu commented Nov 3, 2021

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

zanderso commented Nov 3, 2021

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

zanderso commented Nov 3, 2021

Uh oh!

blasten left a comment

Uh oh!

Uh oh!

Reland Display Features support (Foldable and Cutout) #29447

Reland Display Features support (Foldable and Cutout) #29447

Uh oh!

Conversation

andreidiaconu commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

andreidiaconu commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

andreidiaconu commented Nov 3, 2021

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

zanderso commented Nov 3, 2021

Uh oh!

blasten commented Nov 3, 2021

Uh oh!

zanderso commented Nov 3, 2021

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andreidiaconu commented Nov 1, 2021 •

edited

Loading

andreidiaconu commented Nov 1, 2021 •

edited

Loading