This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix PhysicalShapeLayer paint bounds with clipping disabled #31656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
force-pushed
the
fix_physical_shape_layer_paint_bounds
branch
from
3332531 to
49571ab
Compare
flar
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
Wow, that must have caused a bunch of problems! Can we scan for uninitialized SkRects?
I noticed that there is one in the ::Diff method, but it is initialized by the code that follows it so it is not a bug. Perhaps a ?: initializer rather than declaring it and using if/else might emphasize that it is really being initialized? (just a throwing-code-at-the-wall suggestion)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Feb 28, 2022
…1656) * Fix PhysicalShapeLayer paint bounds with clipping disabled * Add missing SkRect initialization
itsjustkevin
added a commit
that referenced
this pull request
Feb 28, 2022
* Conditionally call FlutterViewDestroyOverlaySurfaces (#31464) * Fix PhysicalShapeLayer paint bounds with clipping disabled (#31656) * Fix PhysicalShapeLayer paint bounds with clipping disabled * Add missing SkRect initialization * 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml' * remove branch ref Co-authored-by: Emmanuel Garcia <[email protected]> Co-authored-by: Matej Knopp <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#98739
If
PhysicalShapeLayerclip_behavior_is set toClip::none, the paint bounds after preroll should include bounds of child layers as well. Otherwise the bounds are calculated incorrectly and the layer may be culled during painting when it shouldn't.If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.