Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Reland "Migrate Flutter Web DOM usage to JS static interop - 3" #33114

Closed
wants to merge 1 commit into from

Conversation

joshualitt
Copy link
Contributor

@joshualitt joshualitt commented May 4, 2022

This is reland of CL 3 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API. The issue with CL 3 is that I incorrectly typed the append method.

Unfortunately, I am not able to repro the crashing issue outside of the framework.

Thankfully, there is test coverage for this on the roll, but not in the engine itself.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 4, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@joshualitt joshualitt changed the title [web] Reland "Migrate Flutter Web DOM usage to JS static interop - 5" [web] Reland "Migrate Flutter Web DOM usage to JS static interop - 3" May 4, 2022
@joshualitt joshualitt force-pushed the html_3 branch 2 times, most recently from c6b9d5a to 9b56d24 Compare May 4, 2022 21:48
@joshualitt joshualitt requested a review from eyebrowsoffire May 4, 2022 21:51
@joshualitt
Copy link
Contributor Author

@joshualitt
Copy link
Contributor Author

Because the fix was so trivial, I attempted to roll this in with CL #4. Leaving this open temporarily in case we need to roll CL #4 back.

@joshualitt joshualitt closed this May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant