This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Reland "Migrate Flutter Web DOM usage to JS static interop - 3" #33114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reland of CL 3 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API. The issue with CL 3 is that I incorrectly typed the
append
method.Unfortunately, I am not able to repro the crashing issue outside of the framework.
Thankfully, there is test coverage for this on the roll, but not in the engine itself.