Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux][A11y] use ATK_ROLE_PASSWORD_TEXT for obscured text #33179

Merged
merged 1 commit into from
May 12, 2022

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented May 6, 2022

This makes TextField(obscureText: true) report its accessiblity role correctly:

Before After
image image

Fixes a small part of flutter/flutter#103191.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jpnurmi
Copy link
Member Author

jpnurmi commented May 9, 2022

@robert-ancell, not sure if you're watching Linux-related engine PRs but here's one. :)

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants