This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[gn] Always set host OS, CPU and target OS, CPU #33266
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all builds, set all of host_os, host_cpu, target_os, target_cpu in
GN. Previously host_os and host_cpu were only set for Host builds and
MacOS target builds.
This reduces some conditional logic and makes the code/build easier to
reason about.
This is cleanup after landing:
#33244
Issue: flutter/flutter#79403
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.