Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

cbracken
Copy link
Member

For all builds, set all of host_os, host_cpu, target_os, target_cpu in
GN. Previously host_os and host_cpu were only set for Host builds and
MacOS target builds.

This reduces some conditional logic and makes the code/build easier to
reason about.

This is cleanup after landing:
#33244

Issue: flutter/flutter#79403

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken added the Work in progress (WIP) Not ready (yet) for review! label May 11, 2022
For all builds, set all of host_os, host_cpu, target_os, target_cpu in
GN. Previously host_os and host_cpu were only set for Host builds and
MacOS target builds.

This reduces some conditional logic and makes the code/build easier to
reason about.

This is cleanup after landing:
#33244

Issue: flutter/flutter#79403
@cbracken cbracken force-pushed the set-hostos-always branch from cfb6c0e to 73eede3 Compare May 11, 2022 19:28
@chinmaygarde
Copy link
Member

Makes sense. Why is this WIP?

@cbracken
Copy link
Member Author

WIP because I was crossing my fingers for a quick win, but it broke a bunch of targets and I haven't yet jumped back to take a look at fixing it up. I still do really want to get this working, since it does make the code much much easier to reason about. I'll close this PR for now and send a new one once I've got the issues worked out.

@cbracken cbracken closed this May 20, 2022
@cbracken cbracken deleted the set-hostos-always branch May 20, 2022 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Work in progress (WIP) Not ready (yet) for review!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants