Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove annotation for getLocaleFromString() #33409

Merged
merged 3 commits into from
May 17, 2022

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented May 17, 2022

Addresses test failure involving using LocalizationPlugin.getLocalefromString(...) in PR #30858 by removing @VisibleForTesting annotation.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@blasten blasten requested a review from Hixie May 17, 2022 00:59
@Hixie
Copy link
Contributor

Hixie commented May 17, 2022

if i understand correctly that this annotation is causing test failures, then:

test-exempt: is tested (and is fixing those tests)

@jonahwilliams
Copy link
Member

Sorry for the trouble: you'll need to pull in master/main to at least 9867003 to get linux_host to pass

@camsim99 camsim99 added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 17, 2022
@fluttergithubbot fluttergithubbot merged commit e0b2485 into flutter:main May 17, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2022
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants