Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix typo "FluttterActivity" in FlutterActivity.java #33543

Closed
wants to merge 1 commit into from

Conversation

nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented May 22, 2022

Fixes flutter/flutter#104366

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

It is fine to combine all outstanding typo fixes into a single commit. The ones I could find from you were #33543 #33544 #33546 #33547 #33548. Repurposing either one and closing the rest works. If you find other typo fixes, feel free to combine them into another PR as well. Going through the ceremony of filing bugs and cross referencing PRs for single character fixes is probably a bit frustrating. Appreciate the contribution though!

@nilsreichardt
Copy link
Contributor Author

See #33547 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo "FluttterActivity" in FlutterActitivy.java
2 participants