Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Eliminate use-after-move #34197

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Eliminate use-after-move #34197

merged 1 commit into from
Jun 21, 2022

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Jun 21, 2022 •
edited
Loading

Eliminates a use-after-move of pipeline_desc (std::optional).
It's used in test expectations after (lines 320-321) the move. This passes by value
like in other tests in this file.

Caught during linter cleanup in #33692.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Eliminate use-after-move
909833c 
pipeline_desc is a std::optional<PipelineDescriptor>. It's used in test
expectations after (lines 320-321) the move. This passes by value like
in other tests.
@cbracken cbracken mentioned this pull request Jun 21, 2022
Merged
8 tasks
@cbracken cbracken merged commit 47988c1 into flutter:main Jun 21, 2022
@cbracken cbracken deleted the fix-use-after-move branch June 21, 2022 18:52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2022
@engine-flutter-autoroll
47988c1 Eliminate use-after-move (flutter/engine#34197)
05675b6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdero bdero bdero approved these changes

@dnfield dnfield dnfield approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbracken @bdero @dnfield