PlatformView Blur for Backdrop Filter #34596

emilyabest · 2022-07-11T23:43:17Z

Description:
This PR applies a Gaussian Blur filter to PlatformViews. Currently, the blur is applied when transform mutations are called, however this PR will be combined with PR #34355 (Create BackdropFilter Mutator) to blur PlatformViews for the backdrop filter mutator.

Fixed issues:

PlatformView was not programmed to blur

Fixes: flutter/flutter#109783

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

shell/platform/darwin/ios/BUILD.gn

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

testing/ios/IosUnitTests/IosUnitTests.xcodeproj/project.pbxproj

cyanglaz · 2022-07-12T17:07:56Z

Also need to rebase or merge upstream/main and resolve conflicts.

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm

shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm

testing/ios/IosUnitTests/IosUnitTests.xcodeproj/project.pbxproj

cyanglaz · 2022-07-18T17:22:24Z

The new tests seem to be failing: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8808283911804283841/+/u/test:_Host_Tests_for_ios_debug_sim__2_/stdout?format=raw

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

…ng the next PR. Still need to test new method calls.

…ed code.

…g point.

chinmaygarde · 2022-07-21T20:16:56Z

@cyanglaz Looks like all the comments have been addressed. But @emilyabest, the test failures do look related.

emilyabest · 2022-07-21T20:50:41Z

@cyanglaz Looks like all the comments have been addressed. But @emilyabest, the test failures do look related.

@chinmaygarde We realized the implementation is missing functionality for multiple backdrop filters and removing backdrop filters. I'm testing that code now and will look into the failing tests after pushing it to the PR. Thanks for looking over the comments!

…ized code.

Fixing rebase diff

cyanglaz · 2022-08-17T16:41:43Z

The scenario test is failing due to blur is implemented in this PR. However, the scenario app uses a none-zero origin for the PlatformView, making the blur not working probably.
We need to fix the step 1 in flutter/flutter#109700 before landing this PR.

cyanglaz · 2022-08-19T17:15:28Z

Need to merge #34355 before landing this.

…ter#35543)" This reverts commit 544c341.

chinmaygarde · 2022-08-25T20:19:29Z

@cyanglaz Trying to understand the status here. Per your last comment, this patch depends on #34355 which landed but had to be reverted due to flutter/flutter#109831 and now the perf fixes are going to be incorporated here. Is that right?

cyanglaz · 2022-08-25T23:13:34Z

@cyanglaz Trying to understand the status here. Per your last comment, this patch depends on #34355 which landed but had to be reverted due to flutter/flutter#109831 and now the perf fixes are going to be incorporated here. Is that right?

Yes, #34355 is now included in this PR with the fix. This PR is now waiting for #35501 to land so the scenario app's backdrop filter blur screenshot can be updated more appropriately in this PR.

cyanglaz

This PR now contains re-landing of #34355 with the fix that the PlatformViews are cleared at the start of each frame + tests.

cc @zanderso Do you mind give it a review?

@LongCatIsLooong I did some change since last LGTM:

Add the re-land of Pushing BackdropFilter Mutator #34355.
Add the code that clears the visited_platform_views_ list at the start of a frame + test.
Updated the screenshot of the scenario app for blurring PlatformView.

cyanglaz · 2022-08-12T16:42:26Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm

+}
+
+- (void)dealloc {
+  [self.blurEffectView release];


Do not reference self in its dealloc state, so

[_blurEffectView release]; _blurEffectView = nil;

cyanglaz · 2022-08-30T18:09:50Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

@@ -777,6 +805,7 @@ - (BOOL)flt_hasFirstResponderInViewHierarchySubtree {
 void FlutterPlatformViewsController::ResetFrameState() {
  slices_.clear();
  composition_order_.clear();
+  visited_platform_views_.clear();


This is the fix for flutter/flutter#109783

cyanglaz · 2022-08-30T18:10:23Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm

@@ -296,6 +1096,86 @@ - (void)testCompositePlatformView {
  XCTAssertTrue(CGRectEqualToRect(platformViewRectInFlutterView, CGRectMake(100, 100, 300, 300)));
 }

+- (void)testBackdropFilterCorrectlyPushedAndReset {


This is the test for This if the fix for flutter/flutter#109783

LongCatIsLooong

The objective C part LGTM

zanderso

I am not super familiar with this code, but I do see where the list of platform views is being cleared, so rslgtm.

cyanglaz · 2022-09-01T18:21:45Z

Wait until flutter/flutter#110688 is landed before landing this.

flar · 2022-09-07T23:06:52Z

flow/layers/backdrop_filter_layer.cc

@@ -43,6 +43,9 @@ void BackdropFilterLayer::Preroll(PrerollContext* context,
                                  const SkMatrix& matrix) {
  Layer::AutoPrerollSaveLayerState save =
      Layer::AutoPrerollSaveLayerState::Create(context, true, bool(filter_));
+  if (context->view_embedder != nullptr) {
+    context->view_embedder->PushFilterToVisitedPlatformViews(filter_);


Shouldn't this push the outstanding clips as well? The filter will only be applied to the region inside those clips. More specifically, the output of the filter on the PlatformView will be clipped by the clips.

Yes, it should when we figure out how to filter a specific region inside the PlatformView.
We should have a follow up PR to support filter only a part of the PlatformView (at least a rect), which will fix flutter/flutter#50183
And the clip path should be added to the method in that PR.

flutter-dashboard bot added the platform-ios label Jul 11, 2022

emilyabest requested a review from cyanglaz July 12, 2022 16:18

cyanglaz suggested changes Jul 12, 2022

View reviewed changes

cyanglaz reviewed Jul 12, 2022

View reviewed changes

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm Outdated Show resolved Hide resolved

emilyabest force-pushed the BackdropView branch from 7fee19e to d2ee0a7 Compare July 12, 2022 18:53

cyanglaz suggested changes Jul 12, 2022

View reviewed changes

emilyabest force-pushed the BackdropView branch from c16525d to f63d016 Compare July 12, 2022 22:56

emilyabest added 2 commits July 15, 2022 11:39

Resolving merge conflicts.

021480d

Removed trailing whitespace

5027753

emilyabest force-pushed the BackdropView branch from f63d016 to 5027753 Compare July 15, 2022 19:16

cyanglaz reviewed Jul 15, 2022

View reviewed changes

emilyabest requested review from LongCatIsLooong and JTKryptic July 15, 2022 19:23

emilyabest added 2 commits July 15, 2022 15:18

Removed conflict code. Initial attempt with backdrop filter case.

24731fa

Removed duplicate test

83b6607

cyanglaz reviewed Jul 18, 2022

View reviewed changes

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h Outdated Show resolved Hide resolved

cyanglaz self-assigned this Jul 18, 2022

emilyabest added 8 commits July 19, 2022 10:39

Reverted code to pass the unit tests. Prepared method calls for mergi…

fb0684c

…ng the next PR. Still need to test new method calls.

Ran whitespace check

31567f4

Bringing back old checks.

2bca987

Updated code to plug into Javon's PR. Started unit tests for integrat…

e830e4a

…ed code.

Saving applyBackdropFilterWithRadius method for reference.

c881e11

Removed applyBackdropFilterWithRadius method. This is the new startin…

81d2d71

…g point.

Updated unit tests to use applyBackdropFilter method

bc2e1b1

Ran clang checks

ff81803

First implementation to allow multiple backdrop filters. Also reorgan…

359a10d

…ized code.

emilyabest added 2 commits August 11, 2022 11:13

Added autorelease after copying _gaussianFilter

3ed695d

Merge branch 'main' into BackdropViewPreRebase

c4ab9cb

Fixing rebase diff

emilyabest force-pushed the BackdropView branch from 3cf0170 to c4ab9cb Compare August 12, 2022 16:39

review feedbacks

a1ca917

Chris Yang added 3 commits August 18, 2022 11:13

remove TODOs

ee25e17

fixes

92cc72b

update golden

1dca0dd

cyanglaz mentioned this pull request Aug 19, 2022

BackdropFilter performance degrades after first appearance of platform view flutter/flutter#109831

Closed

Chris Yang added 2 commits August 22, 2022 15:10

Merge branch 'main' into BackdropView

0702129

Revert "Revert "Pushing BackdropFilter Mutator (flutter#34355)" (flut…

c810c40

…ter#35543)" This reverts commit 544c341.

Chris Yang added 2 commits August 29, 2022 13:25

merge main

a043cca

update golden

fd24904

cyanglaz reviewed Aug 30, 2022

View reviewed changes

LongCatIsLooong approved these changes Sep 1, 2022

View reviewed changes

zanderso approved these changes Sep 1, 2022

View reviewed changes

cyanglaz approved these changes Sep 6, 2022

View reviewed changes

cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2022

auto-submit bot merged commit 81f0924 into flutter:main Sep 6, 2022

engine-flutter-autoroll mentioned this pull request Sep 6, 2022

Roll Flutter Engine from ce97b5a7f944 to 7db0a37ac76c (6 revisions) flutter/flutter#111044

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 6, 2022

81f09241c PlatformView Blur for Backdrop Filter (flutter/engine#34596)

b1583ca

flar reviewed Sep 7, 2022

View reviewed changes

Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022

PlatformView Blur for Backdrop Filter (flutter#34596)

41f0c31

cyanglaz mentioned this pull request Nov 2, 2022

UIKitView should support mutations: backdrop_filter flutter/flutter#43902

Closed

BenjiFarquhar mentioned this pull request Mar 19, 2023

Glassmorphism effect doesnt work over googlemap on iOS RitickSaha/glassmorphism#7

Closed

ahyangnb mentioned this pull request Mar 14, 2025

Error Rounded corner cutting when using UiKitView with BackdropFilter. flutter/flutter#165184

Closed

PlatformView Blur for Backdrop Filter #34596

PlatformView Blur for Backdrop Filter #34596

Uh oh!

Conversation

emilyabest commented Jul 11, 2022 • edited by cyanglaz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cyanglaz commented Jul 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cyanglaz commented Jul 18, 2022

Uh oh!

Uh oh!

chinmaygarde commented Jul 21, 2022

Uh oh!

emilyabest commented Jul 21, 2022

Uh oh!

cyanglaz commented Aug 17, 2022

Uh oh!

cyanglaz commented Aug 19, 2022

Uh oh!

chinmaygarde commented Aug 25, 2022

Uh oh!

cyanglaz commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

cyanglaz Aug 12, 2022

Choose a reason for hiding this comment

Uh oh!

cyanglaz Aug 30, 2022

Choose a reason for hiding this comment

Uh oh!

cyanglaz Aug 30, 2022

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

zanderso left a comment

Choose a reason for hiding this comment

Uh oh!

cyanglaz commented Sep 1, 2022

Uh oh!

flar Sep 7, 2022

Choose a reason for hiding this comment

Uh oh!

cyanglaz Sep 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emilyabest commented Jul 11, 2022 •

edited by cyanglaz

Loading

cyanglaz commented Aug 25, 2022 •

edited

Loading

cyanglaz Sep 8, 2022 •

edited

Loading