Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Undo custom serialization of spell check results on Android #34647

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Undo custom serialization of spell check results on Android #34647

merged 4 commits into from
Jul 13, 2022

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jul 13, 2022 •
edited
Loading

Undoes custom serialization of spell check results on Android as discussed here and changes codec to StandardMethodCodec to match iOS.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@camsim99 camsim99 requested review from justinmc and cyanglaz July 13, 2022 21:13
cyanglaz
cyanglaz approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

justinmc
justinmc approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

shell/platform/android/test/io/flutter/plugin/editing/SpellCheckPluginTest.java Outdated

expectedResult.put("startIndex", 7);
expectedResult.put("endIndex", 12);
expectedResult.put("suggestions", new ArrayList<String>(Arrays.asList("world", "word", "old")));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Would it be beneficial to store these keys as constants somewhere that SpellCheckPlugin.java and this test could both share them?

No need to worry about this is other similar tests don't do this, etc.

@camsim99 camsim99 added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 13, 2022
@fluttergithubbot fluttergithubbot merged commit 0552ef7 into flutter:main Jul 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2022
@engine-flutter-autoroll
0552ef7 Undo custom serialization of spell check results on Android (f…
e46b6e4 
…lutter/engine#34647)
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 15, 2022
@camsim99 @betrevisan
Undo custom serialization of spell check results on Android (flutter#…
672045e 
…34647)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinmc justinmc Awaiting requested review from justinmc

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camsim99 @justinmc @cyanglaz @fluttergithubbot