Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

NNBD migration for //testing #34766

Merged
merged 3 commits into from
Jul 20, 2022
Merged

NNBD migration for //testing #34766

merged 3 commits into from
Jul 20, 2022

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 19, 2022

Addresses two of the items in flutter/flutter#71507

verify_exported seems to "just work." Unfortunately, I don't think it will be run in CI until post submit and I may not have covered all the cases exercised there in my quick local test.

The parse_and_send stuff was relatively trivial to migrate. The fallout if there is anything bad there is we may not get benchmark data showing up.

@dnfield dnfield requested a review from zanderso July 19, 2022 20:45
@zanderso
Copy link
Member

Looks like the benchmark runner has some non-null-safe dependencies.

@dnfield
Copy link
Contributor Author

dnfield commented Jul 20, 2022

metrics_center is assuming some values can't be null in the JSON when in fact they can.

For example, in sound null safety it fails to parse a benchmark json stub like

{
      "name": "ParagraphFixture/TextBigO_RMS",
      "family_index": 5,
      "per_family_instance_index": 0,
      "run_name": "ParagraphFixture/TextBigO",
      "run_type": "aggregate",
      "repetitions": 1,
      "threads": 1,
      "aggregate_name": "RMS",
      "aggregate_unit": "percentage",
      "rms": 4.8948864875330522e-01
    },

because it has no time_unit key.

It will need to be patched and rolled into the engine.

@dnfield
Copy link
Contributor Author

dnfield commented Jul 20, 2022

flutter/packages#2347 needs to roll into this to work.

@dnfield dnfield requested a review from jason-simmons July 20, 2022 20:53
@dnfield
Copy link
Contributor Author

dnfield commented Jul 20, 2022

This looks like it'll be green now.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2022
@auto-submit auto-submit bot merged commit 92f9c4e into flutter:main Jul 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2022
@dnfield dnfield deleted the nnbd branch July 20, 2022 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants