This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Convert Gfx PlatformView to use modern TouchSource API, take 2 #35018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #32877
Revert of #32877: commit 1965c92 (#33471)
This patch: Revert of #33471
fxbug.dev/85125
This PR switches the GfxPlatformView code to use the TouchSource/MouseSource API. After this PR, both GFX and Flatland will receive touch and mouse events over the new APIs, instead of the legacy GFX SessionListener API.
flutter/flutter#102412
=Fuchsia testing=
$ fx test //src/ui/tests
(This is what broke the roll last time)
=Flutter testing=
Test re-enabled: PlatformViewTests.TouchSourceLogicalToPhysicalConversion
$ fx shell run fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cmx
=Product testing=
This PR has been manually validated on a nelson device (today, July 29) running stable production code, with the following UI cases:
Pre-launch Checklist
writing and running engine tests.
///
).