Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Enforce shader resource limits in impellerc #35120

Merged
merged 1 commit into from
Aug 5, 2022
Merged

[Impeller] Enforce shader resource limits in impellerc #35120

merged 1 commit into from
Aug 5, 2022

Conversation

magicianA
Copy link
Member

Fix flutter/flutter#105369

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

chinmaygarde
chinmaygarde approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives us a great way to configure limits. But the values themselves are unchanged from what is allowed today. I think we should land this and file a followup issue to tune these values to ES2 baselines. For instance, not allowing image samplers in the vertex shader.

@magicianA magicianA mentioned this pull request Aug 4, 2022
Closed
@magicianA
Copy link
Member Author

@chinmaygarde Got it. I've filed a issue in flutter/flutter#108960. Maybe you could submit this pr and list the proper value later on?

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 4, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 4, 2022

Validations Fail.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2022
zanderso
zanderso approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased to resolve merge conflicts.

@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2022
@auto-submit auto-submit bot merged commit e1e4a28 into flutter:main Aug 5, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
a8c4c86 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
2226e4e 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
1fdb25e 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
113e1ac 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
abf5f5a 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
087d7db 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
ee5f70e 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
1d734b8 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
dd48e3d 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
660d75a 
…er/engine#35120)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
6c6306a 
…er/engine#35120)
@iskakaushik iskakaushik mentioned this pull request Aug 5, 2022
Closed
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Aug 5, 2022
@magicianA @betrevisan
[Impeller] Enforce shader resource limits in impellerc (flutter#35120)
9432bec
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutt…
bbd0827 
…er/engine#35120)
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 25bad51 to 57f43bd (13 revisions) (#109063)
e158422 
* 7a536ee Roll Dart SDK from 0ab07c889f74 to 16cbbc9d5e4b (1 revision) (flutter/engine#35177)

* e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutter/engine#35120)

* d6931cc Roll Fuchsia Mac SDK from CUZLMQ1lB... to b8WQvI4f0... (flutter/engine#35179)

* c1bb5d7 Roll Dart SDK from 16cbbc9d5e4b to aada0a67f81e (1 revision) (flutter/engine#35180)

* d45c4c4 ColorFilterLayer change SkColorFilter to DLColorFilter (flutter/engine#34744)

* 1a678d2 Roll Fuchsia Linux SDK from BRTz21cLl... to kURZcohuz... (flutter/engine#35182)

* cdccc60 Roll Dart SDK from aada0a67f81e to 344a7d12b413 (1 revision) (flutter/engine#35181)

* 2c7b4f6 Update setAssetDirectory service extension to fail if provided path is invalid (flutter/engine#35178)

* ce3397f fix analysis error (flutter/engine#35187)

* eaeae8e Make it possible to obtain `FontWeight` integer value (flutter/engine#35183)

* 1f9d87d Analyze all dart code on CI (flutter/engine#35147)

* 1cf7023 [impeller] [vulkan] Support textures backed by `vk::Image`s (flutter/engine#35163)

* 57f43bd Roll Skia from 098c234c05f7 to f1245dcd35f8 (23 revisions) (flutter/engine#35189)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@engine-flutter-autoroll @camsim99
Roll Flutter Engine from 25bad51 to 57f43bd (13 revisions) (flutter#1…
3ae10a0 
…09063)

* 7a536ee Roll Dart SDK from 0ab07c889f74 to 16cbbc9d5e4b (1 revision) (flutter/engine#35177)

* e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutter/engine#35120)

* d6931cc Roll Fuchsia Mac SDK from CUZLMQ1lB... to b8WQvI4f0... (flutter/engine#35179)

* c1bb5d7 Roll Dart SDK from 16cbbc9d5e4b to aada0a67f81e (1 revision) (flutter/engine#35180)

* d45c4c4 ColorFilterLayer change SkColorFilter to DLColorFilter (flutter/engine#34744)

* 1a678d2 Roll Fuchsia Linux SDK from BRTz21cLl... to kURZcohuz... (flutter/engine#35182)

* cdccc60 Roll Dart SDK from aada0a67f81e to 344a7d12b413 (1 revision) (flutter/engine#35181)

* 2c7b4f6 Update setAssetDirectory service extension to fail if provided path is invalid (flutter/engine#35178)

* ce3397f fix analysis error (flutter/engine#35187)

* eaeae8e Make it possible to obtain `FontWeight` integer value (flutter/engine#35183)

* 1f9d87d Analyze all dart code on CI (flutter/engine#35147)

* 1cf7023 [impeller] [vulkan] Support textures backed by `vk::Image`s (flutter/engine#35163)

* 57f43bd Roll Skia from 098c234c05f7 to f1245dcd35f8 (23 revisions) (flutter/engine#35189)
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
@magicianA @emilyabest
[Impeller] Enforce shader resource limits in impellerc (flutter#35120)
44e7932
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@magicianA magicianA

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Enforce shader resource limits in impellerc.

4 participants

@magicianA @chinmaygarde @zanderso @ColdPaleLight