[web] roll CanvasKit 0.36.1 (attempt 3) #36005
Conversation
yjbanov
changed the title
| void expectAlmost(double actual, double expected) { | ||
| expect(actual, within<double>(distance: actual / 100, from: expected)); | ||
| } |
There was a problem hiding this comment.
Do you need your own implementation to validate this?
There's already moreOrLessEquals and closeTo that might help here (and probably more!).
expect(actual, moreOrLessEquals(expected, epsilon: actual/100));(Also not sure about using actual as part of the epsilon value... shouldn't it be fixed to guarantee accuracy to X decimal points? Like 0.1 or maybe 1?)
There was a problem hiding this comment.
moreOrLessEquals is from package:flutter_test, which we don't have access to. closeTo is interesting. Right now within is standard in the code base, so I think for now I'll prefer to continue relying on it.
| expectAlmost(paragraph.getLongestLine(), 263); | ||
| expectAlmost(paragraph.getMaxIntrinsicWidth(), 263); | ||
| expectAlmost(paragraph.getMinIntrinsicWidth(), 135); | ||
| expectAlmost(paragraph.getMaxWidth(), 500); |
There was a problem hiding this comment.
In this case, the width can be +-5 of 500 (I assume pixels?). Isn't that delta starting to be "too large" that could start masking actual measurement/rounding errors?
There was a problem hiding this comment.
This whole test is just a smoke test. More precise text measurement tests are in dedicated files. So I'm not worried about the precision here. TBH I'd probably be happy if we just checked that the returned value is not null. That we are also checking for a specific value is a bonus.
| ..decoration = 0x2 | ||
| ..decorationThickness = 2.0 | ||
| ..decorationColor = Float32List.fromList(<double>[13, 14, 15, 16]) | ||
| ..decorationStyle = canvasKit.DecorationStyle.Dotted | ||
| ..textBaseline = canvasKit.TextBaseline.Ideographic | ||
| ..fontSize = 24 | ||
| ..fontSize = 48 |
There was a problem hiding this comment.
Why these changes in fontSize, heightMultiplier and others? (I understand the colors were maybe invalid before, but the rest?)
There was a problem hiding this comment.
I made this test a golden test. Previously the text we rendered was complete nonsense. Now it is displaying something reasonable: https://flutter-engine-gold.skia.org/diff?test=paragraph_kitchen_sink&left=c8f1c90d490826fdbcaf4e2a4762fc76&right=eb3fc116f84bdf3e401fe0345ccde4f3
This roll was reverted in #35837 because of golden failures in the engine=>framework roll, which turned out to be improvements. The new version of CK renders more consistently with non-web versions of Flutter (examples).
Roll CanvasKit to 0.36.1. This brings a fix for certain old Android GPUs that trigger a bug when used through WebGL.
Fixes flutter/flutter#74990
Fixes flutter/flutter#110684