Scribble method namespace #36642
Scribble method namespace #36642
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Depends on flutter/flutter#104128 |
| result:^(id _Nullable result){ | ||
| }]; | ||
|
|
||
| XCTAssertNotEqual(textInputPlugin.activeView.selectionRects, nil); |
There was a problem hiding this comment.
nits: XCTAssertNotNil, although it is not necessary as the next Assert implies textInputPlugin.activeView.selectionRects is not nil.
| [regularField addEntriesFromDictionary:editingValue]; | ||
| [self setClientId:123 configuration:regularField]; | ||
| XCTAssertEqual(self.installedInputViews.count, 1ul); | ||
| XCTAssertNotEqual(textInputPlugin.activeView, nil); |
|
@cyanglaz Good idea about doing this in stages. I've added back the TextInputClient usages so this PR now has both. I'll come back and remove them after this and the framework PR land. |
In the framework (flutter/flutter#104128), the scribble feature is being moved out of TextInputClient and into its own class. This PR updates the naming of the platform channel methods to match their new names in the framework.