This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add DOM TouchEvent modifiers accessors #36836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
bleroux
changed the title
dkwingsmt
reviewed
Oct 18, 2022
| @@ -2571,10 +2610,35 @@ mixin _MultiPointerEventMixin on _BasicEventContext { | |||
| } | |||
| } | |||
|
|
|||
| mixin _KeyboardModifiersMixin on _BasicEventContext { | |||
There was a problem hiding this comment.
My memory to this file is getting vague, but since this mixin is used for all three event classes, can we just add these new properties to _BasicEventContext?
There was a problem hiding this comment.
can we just add these new properties to
_BasicEventContext?
Done, my first implementation was more complex so I did not want to clutter _BasicEventContent.
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 20, 2022
…113761) * 9f09f4ce8 Roll Dart SDK from f21024945abf to 99f266a404bd (1 revision) (flutter/engine#36860) * 3f58c9743 [Impeller] Polyline generation optimization. (flutter/engine#36759) * d6ccb2d67 Roll Skia from af544866f04d to 161637433767 (1 revision) (flutter/engine#36861) * f32d29056 Add DOM TouchEvent modifiers accessors (flutter/engine#36836) * dd9159958 Roll Fuchsia Linux SDK from oMrS1TjaSIjntnBvR... to IvN-WLezL2sS_wSzZ... (flutter/engine#36862) * cfe164f66 [fuchsia][scenic] Fix invalid viewRef error in pointer injection. (flutter/engine#36850) * bd15adf16 Roll Skia from 161637433767 to 50363183d1c7 (3 revisions) (flutter/engine#36864) * e351b05c7 Roll Fuchsia Mac SDK from XZV0Cqcpiv74L7ric... to M5-c50jCcV0ypwYcT... (flutter/engine#36865) * a89ed7a72 Roll Skia from 50363183d1c7 to 572d4e85f83e (1 revision) (flutter/engine#36867) * cca0812cf Roll Skia from 572d4e85f83e to 8928b024556f (1 revision) (flutter/engine#36868) * 488b76725 Roll Skia from 8928b024556f to 025ae7eec03e (6 revisions) (flutter/engine#36869) * 7997edc4f [web] Some cleanup for text tests (flutter/engine#36425) * a831dd269 Roll Skia from 025ae7eec03e to a9255bc938bf (1 revision) (flutter/engine#36870) * 80847c95f [fuchsia][input] Delete legacy pointer handler (flutter/engine#36857) * e4c27fc90 Roll Skia from a9255bc938bf to 4fa600316d1d (6 revisions) (flutter/engine#36872) * 9e635b177 Roll Fuchsia Linux SDK from IvN-WLezL2sS_wSzZ... to zw_jyeiHfJtAXF_qp... (flutter/engine#36875) * a5c5c25ba Roll Skia from 4fa600316d1d to 723ccd171e37 (3 revisions) (flutter/engine#36876) * 2f235c4ba Roll Fuchsia Mac SDK from M5-c50jCcV0ypwYcT... to 7lmBrmhOLwrqoqXk0... (flutter/engine#36877) * 0f0739651 [fuchsia] Bump the Fuchsia target API level to 10 (flutter/engine#36858) * 490b06d13 Roll Skia from 723ccd171e37 to fc7d5c9ee970 (1 revision) (flutter/engine#36878)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds modifiers accessors (
altKey,ctrlKey,metaKey,shiftKey) toDomTouchEventExtension, as defined in the current W3C specification: https://www.w3.org/TR/touch-events/#attributes-2Motivation
Those accessors are needed to implement #36724.
See this review comment: #36724 (review).
Related Issue
Fixes flutter/flutter#113605
Tests
Update 3 tests