Web sdk build reland #36851
Web sdk build reland #36851
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
common/config.gni
Outdated
| @@ -22,6 +22,9 @@ declare_args() { | |||
|
|
|||
| # Whether to use a prebuilt Dart SDK instead of building one. | |||
| flutter_prebuilt_dart_sdk = false | |||
|
|
|||
| # Whether to build the flutter web sdk outline/DDC artifacts. | |||
| build_flutter_web_sdk = false | |||
There was a problem hiding this comment.
Following suit would make this flutter_build_web_sdk.
| argParser.addFlag( | ||
| 'host', | ||
| help: 'Build the host build instead of the wasm build, which is currently' | ||
| 'needed for `flutter run --local-engine` to work' |
|
@eyebrowsoffire Would it be possible to copy the This is needed for the flutter tool to work properly. For some reason, the compiler expects the |
eyebrowsoffire
added
autosubmit
|
Can this PR be reverted it appears to cause the Flutter HHH bot to fail, see https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8799750296394481121/+/u/gn_--full-dart-sdk_--no-prebuilt-dart-sdk/stdout Also see flutter/flutter#113772 for the tracking issue. |
|
We have merged a roll-forward fix: #36926 |
Trying to reland #36520
A few things that are different:
felt build --hostto do the old host build, in case you want to run with--local-enginebefore we've made the changes to the flutter tool to support--local-enginefrom the wasm build.--multi-rootin order to avoid accidentally pulling in any stuff from copied or builtdart-sdkfor the web sdk.There were some issues with the google3 roll so I need to do a little more investigation to make sure I'm not breaking anything there before I land this.