This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Macos re-enable TestSetMenu #37058
Merged
Macos re-enable TestSetMenu #37058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Oct 26, 2022
cyanglaz
added
the
autosubmit
|
auto label is removed for flutter/engine, pr: 37058, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
cyanglaz
force-pushed
the
macos_menutest
branch
from
0b4ded7 to
2ef5090
Compare
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2022
christopherfujino
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 27, 2022
…114178) * c33eae133 Macos re-enable TestSetMenu (flutter/engine#37058) * abc3aabad PlatformView partial blur (flutter/engine#36015) * 8fcf413f8 Revert "PlatformView partial blur" (flutter/engine#37085) * 8bb0441e5 Revert "Fixes Android text field to use hint text for accessibility (#36846)" (flutter/engine#37083)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables the TestSetMenu test.
The workaround in flutter/flutter#104748 (comment) is applied in this PR.
Fixes flutter/flutter#104748
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.