[Impeller] Support user defined structs in buffers, clean up compute tests #37084
Conversation
…und try to create renderer
|
|
||
| TEST_P(ComputeTest, CanCreateComputePass) { | ||
| if (GetParam() == PlaygroundBackend::kOpenGLES) { |
There was a problem hiding this comment.
Did you mean to remove these skips?
There was a problem hiding this comment.
Yes - this now gets skipped in the macro for setting up a compute playground. We can add Vulkan and GLES when/if we start supporting them.
chinmaygarde
changed the title
| }); | ||
| current_byte_offset += stride * array_elements.value_or(1); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I think this adds support for nested structs across all backend and stage types? Might be worth adding a small raster test that uses a nested struct (and make sure the GLES metadata doesn't need to be updated for this).
There was a problem hiding this comment.
Proooobably?
I'll give it a try.
There was a problem hiding this comment.
I'm going to punt on this fornow - I'm still trying to track down what to do about the buffer to texture issue and want to keep making progress on compute right now.
dnfield
added
the
autosubmit
Updates the compute test to add a struct
Updates compiler reflector to support structs in buffers
Updates compute playground tests to not setup a renderer/attempt to setup a renderer.