This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "PlatformView partial blur #36015" #37086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
requested review from
LongCatIsLooong and
flar
and removed request for
LongCatIsLooong
cyanglaz
force-pushed
the
platform_view_partial_blur_reland
branch
from
303f75d to
032baff
Compare
|
The state stack PR is reverted #37090 |
LongCatIsLooong
approved these changes
Oct 27, 2022
This reverts commit 8fcf413.
cyanglaz
force-pushed
the
platform_view_partial_blur_reland
branch
from
032baff to
5710a41
Compare
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relands "PlatformView partial blur #36015"
#36015 caused the tree to break. The issue was caused because the way to get cull_rect has changed in 705939b and the "PlatformView partial blur #36015" did not sync with it before landing.
The fix on top of the original PR is 303f75d
Fixes flutter/flutter#50183
Fixes flutter/flutter#113508
On top of all the new tests passing, I have manually verified that the rect used for blurring is still correct.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.