Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Announce alerts through SemanticsService on Windows" #37120

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

yaakovschectman
Copy link
Contributor

Reverts #36966

Cursor-hover reading in some scenarios is broken.

@yaakovschectman yaakovschectman added the revert Label used to revert changes in a closed and merged pull request. label Oct 28, 2022
@yaakovschectman yaakovschectman self-assigned this Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

This pull request cannot be merged due to conflicts. Please resolve conflicts and re-add the revert label.

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 28, 2022
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaakovschectman yaakovschectman added the revert Label used to revert changes in a closed and merged pull request. label Oct 28, 2022
@yaakovschectman yaakovschectman merged commit 243019f into main Oct 28, 2022
@yaakovschectman yaakovschectman deleted the revert-36966-announce_alert branch October 28, 2022 20:57
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-windows revert Label used to revert changes in a closed and merged pull request.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants