extend const_finder to allow skipping particular classes #37257

christopherfujino · 2022-11-02T21:24:45Z

This updates the const_finder to recognize an annotation with the class name StaticIconProvider, which will lead to all constant references within that class being ignored. This will be a no-op for non-web Flutter builds, however will allow partial tree-shaking for Flutter for web builds (see flutter/flutter#57181 (comment) for why some unused icons will still be retained).

A follow-up framework/tool PR will be required to start calling const_finder during web builds, passing it the web dill and adding the annotation to the Icons class in https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/icons.dart.

I locally confirmed that a dill file created as part of flutter build web --release and a framework that had an @StaticIconProvider() annotation added resulted in most constants no longer being retained.

christopherfujino · 2022-11-09T23:10:41Z

testing/run_tests.py

@@ -837,7 +837,8 @@ def GatherConstFinderTests(build_dir):
      '--disable-dart-dev',
      os.path.join(test_dir, 'const_finder_test.dart'),
      os.path.join(build_dir, 'gen', 'frontend_server.dart.snapshot'),
-      os.path.join(build_dir, 'flutter_patched_sdk')
+      os.path.join(build_dir, 'flutter_patched_sdk'),
+      os.path.join(build_dir, 'dart-sdk', 'lib', 'libraries.json')


This path is needed to do web compilation

Maybe we should pass a Flutter-specific flutter/web_sdk/libraries.json file instead.

you're right, I double checked what we do in the tool, and it's actually that file, will update

Actually, using that file does not work in this test as for dart2js it just points to a relative path to the dart-sdk libraries.json https://github.com/flutter/engine/blob/main/web_sdk/libraries.json#L26. This path ("../dart-sdk/lib/libraries.json") is relative to its position in the Flutter cache, however, not the engine workspace.

Passing the dart-sdk version directly should be functionally equivalent however.

zanderso · 2022-11-09T23:22:19Z

tools/const_finder/bin/main.dart

+  T getArg<T>(String name) {
+    try {
+      return argResults[name] as T;
+    } catch (err) {


Can you catch a specific exception here?

It's a private _CastError. Also, it's being rethrown, this is just a usability convenience to let the user know which flag they didn't provide.

I can update this STDERR to be even more user-friendly...

Actually nvm, let me just mark the options mandatory.

tools/const_finder/lib/const_finder.dart

zanderso · 2022-11-09T23:28:02Z

tools/const_finder/lib/const_finder.dart

+      if (expression is! ConstantExpression) {
+        return false;
+      }
+
+      final DartType type = expression.type;
+      if (type is InterfaceType && type.classNode.name == 'StaticIconProvider') {
+        return true;
+      }
+      return false;


Can you do this? Or does type promotion not work for this?

Suggested change

if (expression is! ConstantExpression) {

return false;

}

final DartType type = expression.type;

if (type is InterfaceType && type.classNode.name == 'StaticIconProvider') {

return true;

}

return false;

return expression is! ConstantExpression

&& expression.type is InterfaceType

&& expression.type.classNode.name == 'StaticIconProvider';

You need to make expression.type a local, the compiler can't promote fields. I can clean this up a little though...

got rid of three lines--I think this is as compact as I can make this without casts.

dnfield · 2022-11-10T00:23:45Z

Seems fine, Alex may want to look at this too since he knows more about what the compiler/kernel stuff is doing here.

skia-gold · 2022-11-10T00:40:29Z

Gold has detected about 1 new digest(s) on patchset 11.
View them at https://flutter-engine-gold.skia.org/cl/github/37257

alexmarkov

Lgtm with comments.

tools/const_finder/lib/const_finder.dart

tools/const_finder/test/const_finder_test.dart

alexmarkov · 2022-11-10T15:25:25Z

testing/run_tests.py

@@ -837,7 +837,8 @@ def GatherConstFinderTests(build_dir):
      '--disable-dart-dev',
      os.path.join(test_dir, 'const_finder_test.dart'),
      os.path.join(build_dir, 'gen', 'frontend_server.dart.snapshot'),
-      os.path.join(build_dir, 'flutter_patched_sdk')
+      os.path.join(build_dir, 'flutter_patched_sdk'),
+      os.path.join(build_dir, 'dart-sdk', 'lib', 'libraries.json')


Maybe we should pass a Flutter-specific flutter/web_sdk/libraries.json file instead.

Co-authored-by: Zachary Anderson <[email protected]>

skia-gold · 2022-11-11T19:55:29Z

Gold has detected about 72 new digest(s) on patchset 13.
View them at https://flutter-engine-gold.skia.org/cl/github/37257

…lutter/engine#37257)

…lutter/engine#37257) (#115189)

…lasses (flutter/engine#37257) (#115189) Commit: 0a5b531cccfc71b1f787e8748bd9f7020807544d

…asses (flutter/engine#37257) (flutter/flutter#115189)

* 338841a Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39e [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8 mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc566 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531 b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee36 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd97 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb00 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 8772768 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201)

…asses (flutter/engine#37257) (flutter/flutter#115189)

whesse · 2022-11-14T13:12:31Z

tools/const_finder/test/const_finder_test.dart

+  void dispose() {
+    for (final String resource in resourcesToDispose) {
+      stdout.writeln('Deleting $resource');
+      File(resource).deleteSync();


This line needs to be wrapped in an exception handler. The failure to find and delete this file in the cleanup phase is causing the test to fail, and our HHH builders to fail (testing head of flutter/flutter, flutter/engine, and dart-lang/sdk together).

I will open a PR to catch this. However, I'm wondering why the file doesn't exist on HHH? Is it never getting created or is some other process deleting it first?

Actually, it looks like the problem is a little bit earlier:

Could not find /b/s/w/ir/cache/builder/engine/src/out/host_debug_unopt/dart-sdk/bin/snapshots/dart2js.dart.snapshot. Have you built the full Dart SDK?

So even if I catch the delete exception, I think this test would fail anyway since it depends on the dart2js snapshot.

This may have been failing because of a change that tried to use the prebuilt SDK, which was reverted. Could it be interacting with flutter/flutter#115242?

The hhh and monorepo builders should be able to build the full SDK, or whatever is needed. But they do not have a prebuilt Dart SDK that they download. The monorepo builder and HHH builder do use --local-engine when running flutter commands: https://dart.googlesource.com/monorepo/+/refs/heads/main

cc @eyebrowsoffire @jonahwilliams may know the answer to @whesse's question.

I don't really have context into this issue. I reverted flutter/flutter#115242 because it broke the flutter tool for me on an m1. I can't imagine that any recepie changes depended on that yet, because the build would have broken after I reverted, or before I landed.

@whesse I think the action item here is--when building the Dart SDK on the HHH bot, ensure that //engine/src/out/host_debug_unopt/dart-sdk/bin/snapshots/dart2js.dart.snapshot is built (I'm assuming that //engine/src/out/host_debug_unopt/dart-sdk/bin/dart is present, since this script also references that binary).

This has caused our HHH builds to fail. The modes where we run const_finder.dart need to have full dart sdk built, since it uses now dart2js. So the GN invocation needs --full-dart-sdk.

On Dart side, I'll updat our recipes in recipes/cl/271382 and monorepo/cl/271384

whesse

The new test is failing consistently on our builders in the test cleanup code.

https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/18219/overview

* wip * extend const_finder_test to compile web dills * add test * add back tests, including non-const for web * update run_tests.py * fix whitespace * clean up test file * add new options to cli * use annotation rather than explicit deny list * clean up * Apply suggestions from code review Co-authored-by: Zachary Anderson <[email protected]> * clean up * code review Co-authored-by: Zachary Anderson <[email protected]>

…asses (flutter/engine#37257) (flutter/flutter#115189)

* 338841a Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39e [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8 mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc566 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531 b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee36 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd97 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb00 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 8772768 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201) * c05d887 Roll Flutter Engine from e63c9443bc04 to 9500d8c4a4ce (2 revisions) (flutter/flutter#115212) * 1f82985 1c8c23754 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554) (flutter/flutter#115214) * 61b3d5a a0d8cd68c Add a limit to the Gaussian blur downsampling curve (flutter/engine#37550) (flutter/flutter#115217) * 2bf64aa fd56b7ee8 Roll Fuchsia Mac SDK from j3vspnGJcQvIfsXXu... to iPqmEVwAbmYwPlh5a... (flutter/engine#37557) (flutter/flutter#115218) * 53ab17d Roll Flutter Engine from fd56b7ee87f0 to 1ae285897eae (2 revisions) (flutter/flutter#115220) * 4488166 d4e2188e9 [Impeller] Fix DrawPaint regression (flutter/engine#37561) (flutter/flutter#115222) * bf906e6 2bdeaf7d7 Fix inertia cancel event on macOS Ventura (flutter/engine#37067) (flutter/flutter#115226) * 1a19409 06c390470 Roll Fuchsia Mac SDK from iPqmEVwAbmYwPlh5a... to N-iOLgSVYYh_AfC7Q... (flutter/engine#37566) (flutter/flutter#115236) * 1a460cf 54795869b Roll Skia from c0f87aed019b to 38edf6197aa9 (1 revision) (flutter/engine#37567) (flutter/flutter#115239) * 8230ef5 Revert "[web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (#114639)" (flutter/flutter#115242) * 8994920 7269f2f91 Roll Skia from 38edf6197aa9 to 0f515e97d535 (1 revision) (flutter/engine#37571) (flutter/flutter#115244) * 7ac00f7 40b071c75 Roll Fuchsia Linux SDK from IE4logHFoa8ZZQAw3... to AE_mBWzdDqUvn4r1N... (flutter/engine#37572) (flutter/flutter#115247) * fa94a3c b63e6cf55 [Impeller] dont include sampler offset in float offset (flutter/engine#37573) (flutter/flutter#115248) * cb224d1 b7567b92c Roll Fuchsia Mac SDK from N-iOLgSVYYh_AfC7Q... to WYzUv6RnWjJpAiqYp... (flutter/engine#37575) (flutter/flutter#115252) * d587fe4 a1b5507e5 Add playground to demonstrate mask blur problems (flutter/engine#37574) (flutter/flutter#115260) * f5205b1 6f7447efa Roll Fuchsia Linux SDK from AE_mBWzdDqUvn4r1N... to dRHIZSishiboEHMdw... (flutter/engine#37577) (flutter/flutter#115266) * 2c4051f b077c1c46 Roll Dart SDK from 996fe4d7ea9a to 45b7433f9015 (1 revision) (flutter/engine#37578) (flutter/flutter#115271) * 0b5f3fd 743cec5ba Roll Skia from 0f515e97d535 to b2109e6bbbe7 (1 revision) (flutter/engine#37580) (flutter/flutter#115279) * 80bcc3a 035313ae2 Roll Dart SDK from 45b7433f9015 to 7cbcf48157cf (1 revision) (flutter/engine#37582) (flutter/flutter#115281) * fdd2fe4 036f8ea88 Roll Fuchsia Mac SDK from WYzUv6RnWjJpAiqYp... to XvXKIR_SSUfSyGwxe... (flutter/engine#37583) (flutter/flutter#115293) * 436fb4c c290de693 Roll Skia from b2109e6bbbe7 to 2ad14e25f6f7 (7 revisions) (flutter/engine#37585) (flutter/flutter#115294) * 2449907 Fixed the color curve issue (flutter/flutter#115188) * 9359c25 1a79e8686 [macOS] Move to new update semantics embedder API (flutter/engine#37404) (flutter/flutter#115301) * 59e1edc Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (flutter/flutter#115302) * f2ec1c4 42bc762b6 Roll Skia from 2ad14e25f6f7 to a434f9b69660 (11 revisions) (flutter/engine#37591) (flutter/flutter#115304) * ea4e11d Fix test in preparation of the Dart VM dropping support for language versions < 2.12.0 (flutter/flutter#115176) * a0a7b3a 14ecaeb91 [Impeller] error earlier on uint types (flutter/engine#37593) (flutter/flutter#115308) * 2e51077 Do not strip architecture suffixes from host local-engine (flutter/flutter#115320) * 8e3ea14 Incorrect rendering of `SnapshotWidget` (flutter/flutter#114400) * 59ecc75 [flutter_tools] add uint compilation test (flutter/flutter#115317) * 1aeb172 Roll Flutter Engine from 14ecaeb915e0 to 78ae2414003a (10 revisions) (flutter/flutter#115335) * e391812 9dedab305 Roll Skia from b474a43dcc34 to 2cebc1ce363c (2 revisions) (flutter/engine#37612) (flutter/flutter#115338) * 9d64a0f 31ee28684 Combine results of all the test batches. (flutter/engine#37610) (flutter/flutter#115340) * e9c6212 [Impeller] Add shader include with FlutterFragCoord for use by FragmentProgram (flutter/flutter#114214) * a27bb3c 06bd5a816 Roll Skia from 2cebc1ce363c to d758b240cad0 (1 revision) (flutter/engine#37614) (flutter/flutter#115341) * abbffcc c6a513ecd Roll Fuchsia Mac SDK from XvXKIR_SSUfSyGwxe... to 32kfSm94FGtJJeUjg... (flutter/engine#37615) (flutter/flutter#115344) * 0f56ed1 f01de9f6b Roll Skia from d758b240cad0 to 24523449b1b3 (1 revision) (flutter/engine#37616) (flutter/flutter#115346) * 25d74e6 0b338ed86 Roll Dart SDK from 6f5478a58387 to 987faaf6d1d4 (2 revisions) (flutter/engine#37617) (flutter/flutter#115352) * 1f28f99 721fbe111 Roll Skia from 24523449b1b3 to 4d519a8ba97a (3 revisions) (flutter/engine#37618) (flutter/flutter#115354) * c37f255 [tools] Fix plugin_ffi template lint violation (flutter/flutter#115356) * 3c3f136 b4fd07fa4 Roll Dart SDK from 987faaf6d1d4 to 42f87c0521f8 (1 revision) (flutter/engine#37619) (flutter/flutter#115362) * 2ed5283 58495f077 [Impeller] Add debug names to additional VK objects (flutter/engine#37592) (flutter/flutter#115363) * afafde6 7f74f34a4 Roll Fuchsia Linux SDK from B0OuUvWOY24LI1WoF... to agStiOtzmc9Fmw6gc... (flutter/engine#37621) (flutter/flutter#115365) * af2ec91 Roll Plugins from 3ca3410 to e500884 (10 revisions) (flutter/flutter#115366) * 3a298d0 Roll Flutter Engine from 7f74f34a408a to eead7b0d8656 (2 revisions) (flutter/flutter#115369) * acf01eb 905862722 [dart] Run generate_sdk_version_file.py to be compatible with dart ch… (flutter/engine#37624) (flutter/flutter#115372) * 95ace11 Include initial offset when using PlatformViewSurface (flutter/flutter#114103) * 39a9ed5 Updated tokens to v0.141 (flutter/flutter#115298) * ba47c29 216702f3d Roll Skia from 1991515dd191 to 826b3ea577f3 (4 revisions) (flutter/engine#37628) (flutter/flutter#115377) * 2d77ac5 49f8326df Roll Skia from 826b3ea577f3 to 02e2101a75f7 (4 revisions) (flutter/engine#37631) (flutter/flutter#115385) * 136b46b Hint text semantics to be excluded in a11y read out if textfield in not empty and label text is provided (flutter/flutter#115010) * 700de09 Change button and label text to sentence case for Material 3 (flutter/flutter#115187) * b2b8391 Roll Flutter Engine from 49f8326df6f0 to 84cb1f833ac4 (3 revisions) (flutter/flutter#115387) * 2c44f4a Remove dev branch reference from build ios-frameworks error (flutter/flutter#115166) * 792eefe Roll Flutter Engine from 84cb1f833ac4 to af6e47f1d5c4 (4 revisions) (flutter/flutter#115395) * 341a9b1 6d41b2ffb update Scene.toImageSync test to use proper bounds in the request (flutter/engine#37638) (flutter/flutter#115398) * e66183d Bump github/codeql-action from 2.1.25 to 2.1.32 (flutter/flutter#115394) * d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutter#115175) * 349d648 baad8f2c5 Roll Skia from 02e2101a75f7 to cfb6de45f39b (7 revisions) (flutter/engine#37640) (flutter/flutter#115399) * 7d2b011 Fix logic error in `markNeedsPaint` (flutter/flutter#112735) * 93c4b09 Add `RestorableEnumN<T>` and `RestorableEnum<T>` to restorable primitive types (flutter/flutter#115050) * 2c1536a Create a main alias for master channel. (flutter/flutter#115388) * bbb349b Roll Flutter Engine from baad8f2c553b to e56ed93faab5 (6 revisions) (flutter/flutter#115406) * bacd770 c062f7ea7 Roll Skia from cfb6de45f39b to cdf8348e6fba (4 revisions) (flutter/engine#37649) (flutter/flutter#115407) * 27ff6a5 Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (flutter/flutter#115410) * 58728c6 Roll Flutter Engine from 03e9a97f8abe to 21a572e4e4d0 (2 revisions) (flutter/flutter#115411) * e54c8a8e2 3e15c1925 Roll Dart SDK from 7163c9627d98 to c3f1b3642181 (2 revisions) (flutter/engine#37664) (flutter/flutter#115417) * 484e09e Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (flutter/flutter#115423) * 4fdaf7a Revert "Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (#115423)" (flutter/flutter#115456) * 4301731 Make Flutter Driver actively wait for runnable isolate (flutter/flutter#113969) * c940f31 Marks Mac_ios flavors_test_ios to be unflaky (flutter/flutter#115458) * 243a830 Roll Flutter Engine from 3e15c192560f to 223e1f092dd5 (4 revisions) (flutter/flutter#115463) * d7454d5 removing default values for [reporter] and [timeout] in flutter test (flutter/flutter#115160) * a2233ea [flutter_tools] remove all body_might_complete_normally_catch_error ignores (flutter/flutter#115184) * b5345ff d72164776 Revert "[Impeller] Refactor color source resolution to use explicit factory types (#37656)" (flutter/engine#37673) (flutter/flutter#115467) * dcae424 [tools]build ipa validate template icon files (flutter/flutter#114841)

* 338841a Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39e [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8 mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc566 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531 b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee36 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd97 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb00 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 8772768 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201)

mkustermann · 2022-11-22T13:07:08Z

tools/const_finder/test/const_finder_test.dart

+      'compile',
+      'js',
+      '--libraries-spec=$librariesSpec',
+      '-Ddart.vm.product=true',


@sigmundch Does -Ddart.vm.product=true have any impact on this dart compile js command? (I thought of this as a VM-specific constant)

It does. The Flutter Web uses the constant within the flutter framework/engine code. They use it, for example, to choose whether certain code path is executed (e.g. debug only code).

…lutter/engine#37257) (flutter#115189)

* 338841a Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39e [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8 mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc566 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531 b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee36 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd97 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb00 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 8772768 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201)

christopherfujino force-pushed the extend-const-finder-to-skip-classes branch 3 times, most recently from e4ce06a to efb530a Compare November 9, 2022 19:26

christopherfujino commented Nov 9, 2022

View reviewed changes

christopherfujino requested review from zanderso and dnfield November 9, 2022 23:14

christopherfujino marked this pull request as ready for review November 9, 2022 23:14

christopherfujino requested a review from sigmundch November 9, 2022 23:14

christopherfujino mentioned this pull request Nov 9, 2022

Support --tree-shake-icons for the web flutter/flutter#57181

Closed

zanderso reviewed Nov 9, 2022

View reviewed changes

dnfield requested a review from alexmarkov November 10, 2022 00:23

alexmarkov approved these changes Nov 10, 2022

View reviewed changes

christopherfujino and others added 13 commits November 11, 2022 10:27

wip

f35217c

extend const_finder_test to compile web dills

f06d70a

add test

779e03a

add back tests, including non-const for web

6785ce6

update run_tests.py

7abff6d

fix whitespace

66c5236

clean up test file

e7d1185

add new options to cli

6d0431d

use annotation rather than explicit deny list

4f2a9a3

clean up

1263b6d

Apply suggestions from code review

ac499c7

Co-authored-by: Zachary Anderson <[email protected]>

clean up

0977118

code review

5894e4b

christopherfujino force-pushed the extend-const-finder-to-skip-classes branch from c3ebf19 to 5894e4b Compare November 11, 2022 19:20

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 11, 2022

christopherfujino deleted the extend-const-finder-to-skip-classes branch November 11, 2022 23:38

engine-flutter-autoroll mentioned this pull request Nov 12, 2022

Roll Flutter Engine from 329900fc85d6 to b6e45ae354b0 (1 revision) flutter/flutter#115189

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2022

b6e45ae35 extend const_finder to allow skipping particular classes (f…

542c386

…lutter/engine#37257)

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 12, 2022

b6e45ae35 extend const_finder to allow skipping particular classes (f…

0a5b531

…lutter/engine#37257) (#115189)

sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Nov 12, 2022

flutter: b6e45ae35 extend const_finder to allow skipping particular c…

c1fe711

…lasses (flutter/engine#37257) (#115189) Commit: 0a5b531cccfc71b1f787e8748bd9f7020807544d

This was referenced Nov 12, 2022

Roll Flutter from 098aac7ffeef to 61e927d22fe6 (16 revisions) flutter/plugins#6694

Merged

Roll Flutter from 098aac7ffeef to 61e927d22fe6 (16 revisions) flutter/packages#2804

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2022

0a5b531 b6e45ae35 extend const_finder to allow skipping particular cl…

01e720e

…asses (flutter/engine#37257) (flutter/flutter#115189)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 12, 2022

0a5b531 b6e45ae35 extend const_finder to allow skipping particular cl…

983458a

…asses (flutter/engine#37257) (flutter/flutter#115189)

engine-flutter-autoroll mentioned this pull request Nov 12, 2022

Roll Flutter from 098aac7ffeef to 61e927d22fe6 (16 revisions) flutter/packages#2805

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2022

0a5b531 b6e45ae35 extend const_finder to allow skipping particular cl…

4b999a2

…asses (flutter/engine#37257) (flutter/flutter#115189)

engine-flutter-autoroll mentioned this pull request Nov 12, 2022

Roll Flutter from 098aac7ffeef to c05d887f58a2 (17 revisions) flutter/packages#2806

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2022

0a5b531 b6e45ae35 extend const_finder to allow skipping particular cl…

39cf163

…asses (flutter/engine#37257) (flutter/flutter#115189)

engine-flutter-autoroll mentioned this pull request Nov 13, 2022

Roll Flutter from 098aac7ffeef to 1a460cfb93c3 (25 revisions) flutter/packages#2807

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2022

0a5b531 b6e45ae35 extend const_finder to allow skipping particular cl…

5211f55

…asses (flutter/engine#37257) (flutter/flutter#115189)

whesse reviewed Nov 14, 2022

View reviewed changes

christopherfujino mentioned this pull request Nov 14, 2022

catch file system exception in constfindertest #37586

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2022

0a5b531 b6e45ae35 extend const_finder to allow skipping particular cl…

5f5f4c2

…asses (flutter/engine#37257) (flutter/flutter#115189)

mkustermann reviewed Nov 22, 2022

View reviewed changes

christopherfujino mentioned this pull request Dec 6, 2022

[flutter_tools] tree shake icons from web builds flutter/flutter#115886

Merged

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022

b6e45ae35 extend const_finder to allow skipping particular classes (f…

4b8124c

…lutter/engine#37257) (flutter#115189)

gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023

b6e45ae35 extend const_finder to allow skipping particular classes (f…

30b95cb

…lutter/engine#37257) (flutter#115189)

extend const_finder to allow skipping particular classes #37257

extend const_finder to allow skipping particular classes #37257

Uh oh!

Conversation

christopherfujino commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christopherfujino Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield commented Nov 10, 2022

Uh oh!

skia-gold commented Nov 10, 2022

Uh oh!

alexmarkov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skia-gold commented Nov 11, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

whesse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

christopherfujino commented Nov 2, 2022 •

edited

Loading

christopherfujino Nov 11, 2022 •

edited

Loading