Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use iOS 16 APIs to rotate orientation #37302

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 4, 2022

Re-land #36874, which was reverted during a roll because of iOS SDK issues: #37165


On iOS 16:

BUG IN CLIENT OF UIKIT: Setting UIDevice.orientation is not supported. Please use UIWindowScene.requestGeometryUpdate(_:)

Fixes flutter/flutter#111587

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 4, 2022
@jiahaog
Copy link
Member

jiahaog commented Nov 4, 2022

I'll try to run a TGP after 7pm PST to double check as well

@jiahaog
Copy link
Member

jiahaog commented Nov 4, 2022

I'll try to run a TGP after 7pm PST to double check as well

This has passed, once again sorry for the trouble!

@jmagman
Copy link
Member Author

jmagman commented Nov 4, 2022

Thank you @jiahaog!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2022
@auto-submit auto-submit bot merged commit 9584880 into flutter:main Nov 4, 2022
@jmagman jmagman deleted the rotate branch November 4, 2022 18:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 4, 2022
…114710)

* 9584880f4 Use iOS 16 APIs to rotate orientation (flutter/engine#37302)

* 2ac9c73f6 Move primitive type to pipeline descriptor (flutter/engine#37315)

* 6950689ed Roll Skia from 7a45d3123f8b to dc49f35e1ac6 (6 revisions) (flutter/engine#37319)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#114710)

* 9584880f4 Use iOS 16 APIs to rotate orientation (flutter/engine#37302)

* 2ac9c73f6 Move primitive type to pipeline descriptor (flutter/engine#37315)

* 6950689ed Roll Skia from 7a45d3123f8b to dc49f35e1ac6 (6 revisions) (flutter/engine#37319)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#114710)

* 9584880f4 Use iOS 16 APIs to rotate orientation (flutter/engine#37302)

* 2ac9c73f6 Move primitive type to pipeline descriptor (flutter/engine#37315)

* 6950689ed Roll Skia from 7a45d3123f8b to dc49f35e1ac6 (6 revisions) (flutter/engine#37319)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
3 participants