Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix boolean json property. #37403

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix boolean json property. #37403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ targets:
cores: "32"
gcs_goldens_bucket: flutter_logs
gclient_custom_vars: >-
{"download_emsdk": True}
{"download_emsdk": true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the double quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we are passing the string directly to the json parser if we quote it then it will be evaluated as string instead of boolean.

dependencies: >-
[
{"dependency": "goldctl", "version": "git_revision:3a77d0b12c697a840ca0c7705208e8622dc94603"}
Expand Down Expand Up @@ -410,7 +410,7 @@ targets:
add_recipes_cq: "true"
gcs_goldens_bucket: flutter_logs
gclient_custom_vars: >-
{"download_emsdk": True}
{"download_emsdk": true}
dependencies: >-
[
{"dependency": "goldctl", "version": "git_revision:3a77d0b12c697a840ca0c7705208e8622dc94603"}
Expand Down