Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adding release_build:true to Mac builds. #37478

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

yusuf-goog
Copy link
Contributor

This will run the specified jobs under the release builder recipe in dart-internal.

Bug:b/232552448

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • [] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This will run the specified jobs under the release builder recipe in dart-internal.

Bug:b/232552448
@yusuf-goog yusuf-goog requested a review from godofredoc November 9, 2022 19:09
@yusuf-goog
Copy link
Contributor Author

@godofredoc
Copy link
Contributor

@godofredoc pretty much all builds failed: https://chromium-swarm.appspot.com/tasklist?f=parent_task_id-tag%3A5e768f853bb41c11&st=1668020046391

Can you please share the main build link? there are many unexpected builds in that link

@yusuf-goog yusuf-goog self-assigned this Nov 10, 2022
@yusuf-goog yusuf-goog added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2022
@auto-submit auto-submit bot merged commit 80e31ed into flutter:main Nov 10, 2022
@yusuf-goog yusuf-goog deleted the macrb branch November 10, 2022 21:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 10, 2022
…115118)

* 4f86f229d Update FlutterView.java (flutter/engine#37312)

* 80e31edb2 Adding release_build:true to Mac builds. (flutter/engine#37478)

* 2f5b7ac34 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822)

* f831382b7 Install CIPD ninja using DEPS (flutter/engine#37375)

* 4cb9c1e00 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
This will run the specified jobs under the release builder recipe in dart-internal.

Bug:b/232552448
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115118)

* 4f86f229d Update FlutterView.java (flutter/engine#37312)

* 80e31edb2 Adding release_build:true to Mac builds. (flutter/engine#37478)

* 2f5b7ac34 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822)

* f831382b7 Install CIPD ninja using DEPS (flutter/engine#37375)

* 4cb9c1e00 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115118)

* 4f86f229d Update FlutterView.java (flutter/engine#37312)

* 80e31edb2 Adding release_build:true to Mac builds. (flutter/engine#37478)

* 2f5b7ac34 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822)

* f831382b7 Install CIPD ninja using DEPS (flutter/engine#37375)

* 4cb9c1e00 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants