This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Include AndroidSurfaceVulkanImpeller behind a flag. #37486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chingjun
approved these changes
Nov 10, 2022
| @@ -16,7 +16,9 @@ | |||
| #include "flutter/shell/platform/android/android_surface_gl_impeller.h" | |||
| #include "flutter/shell/platform/android/android_surface_gl_skia.h" | |||
| #include "flutter/shell/platform/android/android_surface_software.h" | |||
| #ifdef IMPELLER_ENABLE_VULKAN // b/258506856 for why this is behind an ifdef | |||
There was a problem hiding this comment.
Nit: Should we use #if instead of #ifdef just to be a bit safer? Seems like #if us more common than #ifdef in flutter/engine
This is to enable building in google3. See also: b/258506856
iskakaushik
force-pushed
the
b/258506856
branch
from
d0a46c3 to
6c497c3
Compare
iskakaushik
added
the
autosubmit
chinmaygarde
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 10, 2022
…115048) * 7a746dd9c Add external factories for @staticInterop classes instead of synthetic constructor (flutter/engine#37443) * b42ed6933 Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#37486)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
This is to enable building in google3. See also: b/258506856
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115048) * 7a746dd9c Add external factories for @staticInterop classes instead of synthetic constructor (flutter/engine#37443) * b42ed6933 Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#37486)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115048) * 7a746dd9c Add external factories for @staticInterop classes instead of synthetic constructor (flutter/engine#37443) * b42ed6933 Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#37486)
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable building in google3.
See also: b/258506856