This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Register native callback before running engine. #37600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-wallen
force-pushed
the
add_native_callback_correct
branch
from
a367338 to
bafb04e
Compare
jason-simmons
approved these changes
Nov 15, 2022
a-wallen
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2022
…115369) * 7a4b112d7 Roll Skia from 4d519a8ba97a to 1991515dd191 (1 revision) (flutter/engine#37622) * eead7b0d8 Place native callback registration before running engine (flutter/engine#37600)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
Co-authored-by: a-wallen <[email protected]>
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115369) * 7a4b112d7 Roll Skia from 4d519a8ba97a to 1991515dd191 (1 revision) (flutter/engine#37622) * eead7b0d8 Place native callback registration before running engine (flutter/engine#37600)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115369) * 7a4b112d7 Roll Skia from 4d519a8ba97a to 1991515dd191 (1 revision) (flutter/engine#37622) * eead7b0d8 Place native callback registration before running engine (flutter/engine#37600)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorders the native callback registration before the engine is run. If the callback is registered after the engine runs then there is a race.
Fixes flutter/flutter#115245 (comment)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.