-
Notifications
You must be signed in to change notification settings - Fork 6k
delete fontface polyfill #37652
delete fontface polyfill #37652
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if Yegor's suggested changes are made
0385528
to
09f3939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
test-exempt: removing code |
…115592) * ac874d676 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1ff5 Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a4058 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab3c Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
…lutter#115592) * ac874d676 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1ff5 Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a4058 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab3c Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
…lutter#115592) * ac874d676 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1ff5 Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a4058 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab3c Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
support or IE11 and old Edge has been removed. Removed FontFace Polyfills as well
fixes: flutter/flutter#115013
Pre-launch Checklist
///
).