Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

delete fontface polyfill #37652

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

alanwutang11
Copy link
Contributor

@alanwutang11 alanwutang11 commented Nov 16, 2022

support or IE11 and old Edge has been removed. Removed FontFace Polyfills as well

fixes: flutter/flutter#115013

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Nov 16, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if Yegor's suggested changes are made

@alanwutang11 alanwutang11 force-pushed the delete-fontface-polyfill branch from 0385528 to 09f3939 Compare November 17, 2022 18:44
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@Hixie
Copy link
Contributor

Hixie commented Nov 17, 2022

test-exempt: removing code

@alanwutang11 alanwutang11 merged commit dd12a40 into flutter:main Nov 17, 2022
@alanwutang11 alanwutang11 deleted the delete-fontface-polyfill branch November 17, 2022 20:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 17, 2022
…115592)

* ac874d676 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593)

* bc86c1ff5 Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723)

* dd12a4058 delete fontface polyfill (flutter/engine#37652)

* 1e1a4ab3c Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115592)

* ac874d676 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593)

* bc86c1ff5 Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723)

* dd12a4058 delete fontface polyfill (flutter/engine#37652)

* 1e1a4ab3c Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115592)

* ac874d676 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593)

* bc86c1ff5 Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723)

* dd12a4058 delete fontface polyfill (flutter/engine#37652)

* 1e1a4ab3c Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] delete FontFace polyfills for IE11 and old Edge
4 participants