Add back tooltip to Embedder #37676
Add back tooltip to Embedder #37676
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -1292,6 +1292,7 @@ FlutterSemanticsNode CreateEmbedderSemanticsNode( | |||
| node.customAccessibilityActions.size(), | |||
| node.customAccessibilityActions.data(), | |||
| node.platformViewId, | |||
| node.tooltip.c_str(), | |||
There was a problem hiding this comment.
Could we test this by updating the Dart fixture to have a node with a tooltip and verifying that in accessibility test?
| @@ -101,6 +103,7 @@ TEST_F(EmbedderA11yTest, A11yTreeIsConsistent) { | |||
| ASSERT_EQ(7.0, node->transform.pers0); | |||
| ASSERT_EQ(8.0, node->transform.pers1); | |||
| ASSERT_EQ(9.0, node->transform.pers2); | |||
| ASSERT_EQ(std::strncmp(tooltip, node->tooltip, sizeof(tooltip) - 1), 0); | |||
There was a problem hiding this comment.
Please update A11yTreeIsConsistentUsingLegacyCallbacks below too
| @@ -24,6 +24,8 @@ namespace testing { | |||
|
|
|||
| using EmbedderA11yTest = testing::EmbedderTest; | |||
|
|
|||
| const static char tooltip[] = "tooltip"; | |||
There was a problem hiding this comment.
This can be constexpr (and kTooltip).
…115504) * d7f49f605 Add back tooltip to Embedder (flutter/engine#37676) * c5e6a38dd Fix potential null-point references (flutter/engine#37678)
…lutter#115504) * d7f49f605 Add back tooltip to Embedder (flutter/engine#37676) * c5e6a38dd Fix potential null-point references (flutter/engine#37678)
…lutter#115504) * d7f49f605 Add back tooltip to Embedder (flutter/engine#37676) * c5e6a38dd Fix potential null-point references (flutter/engine#37678)
PR #37192 accidentally removed the tooltip property when creating
FlutterSemanticsNodein the embedder. This PR adds it back so that tooltips are again used by a11y.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.