Roll Firefox to CIPD with dev/browser_roller.dart
#37692
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 1 new digest(s) on patchset 1. |
| // For now, we only test Firefox on Linux. | ||
| if (platform.os == 'linux') { | ||
| await _rollFirefox(platform); | ||
| } |
There was a problem hiding this comment.
Instead of fishing linux out of the for loop, it's probably simpler to just call it after the loop passing it linux?
There was a problem hiding this comment.
That would mean either hard-coding that the linux platform is _platforms[0] or copying the platform constructor _Platform('linux', 'amd64', LinuxPlatformBinding())
…115516) * f78b01f21 Roll Firefox to CIPD with `dev/browser_roller.dart` (flutter/engine#37692) * cb403c1fe Roll Fuchsia Mac SDK from uhjeOxDSb9z-mNpGS... to -Y6svEFnJjmSFQGPZ... (flutter/engine#37695)
…lutter#115516) * f78b01f21 Roll Firefox to CIPD with `dev/browser_roller.dart` (flutter/engine#37692) * cb403c1fe Roll Fuchsia Mac SDK from uhjeOxDSb9z-mNpGS... to -Y6svEFnJjmSFQGPZ... (flutter/engine#37695)
…lutter#115516) * f78b01f21 Roll Firefox to CIPD with `dev/browser_roller.dart` (flutter/engine#37692) * cb403c1fe Roll Fuchsia Mac SDK from uhjeOxDSb9z-mNpGS... to -Y6svEFnJjmSFQGPZ... (flutter/engine#37695)
Engine-side piece for flutter/flutter#115404
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.