Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

jason-simmons
Copy link
Member

This roll changed a VulkanMemoryAllocator API

This roll changed a VulkanMemoryAllocator API
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2022
@auto-submit auto-submit bot merged commit b5d19f8 into flutter:main Dec 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 13, 2022
…117015)

* b5d19f86e Manual roll of Skia from 971c342c3030 to 280ac8882cff (flutter/engine#38257)

* 82dafdfc1 Roll Fuchsia Linux SDK from 8O5rMR_ehMaL3YhZ5... to A0jnUUORf2LQu1z2V... (flutter/engine#38258)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Dec 16, 2022
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#117015)

* b5d19f86e Manual roll of Skia from 971c342c3030 to 280ac8882cff (flutter/engine#38257)

* 82dafdfc1 Roll Fuchsia Linux SDK from 8O5rMR_ehMaL3YhZ5... to A0jnUUORf2LQu1z2V... (flutter/engine#38258)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants