[fuchsia][scenic] Use infinite hit region

[jaeheon]

fxbug.dev/118729

This patchset uses the new "infinite" hit region offered by Flatland. It makes the input interceptor less error prone.

Issue 118006

Pre-launch Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• [x I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the [CLA].
• All existing and new tests are passing.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[abrush21]

Changes LGTM. I think we could add a unit test where intercept_all_input = true, which would exercise the new behavior.

[jaeheon]

Yes, agreed. Will work on it, then push a next version. Jaeheon

…

On Thu, Jan 5, 2023 at 4:32 PM Alexander Brusher ***@***.***> wrote: ***@***.**** commented on this pull request. Changes LGTM. I think we could add a unit test where intercept_all_input = true, which would exercise the new behavior. — Reply to this email directly, view it on GitHub <#38647 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABETUFSOZALSGUVDW5KDADWQ5DY7ANCNFSM6AAAAAATRJQ2M4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jaeheon]

Alex, PTAL. Fakes updated, test cobbled together. I tried trimming the test down, but LMK if there's more I can cut out. Also I filed fxbug.dev/118945 to track getting Flutter repo using Fuchsia SDK's Fake Flatland. Likely Emircan will get to it soon.