[embedder] Fix getting vkGetInstanceProcAddr #39051
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nanokatze
force-pushed
the
vk_embedder
branch
from
3d910cf to
ac2b4fd
Compare
nanokatze
force-pushed
the
vk_embedder
branch
from
ac2b4fd to
801d9e4
Compare
|
I believe this is a breaking change. Can we check for both the prefixed and non-prefixed versions? |
I have opened a follow up PR that addresses this: #39081 |
…119081) * 22084db7a Remove unnecessary null checks in doc snippet (flutter/engine#39071) * f91890636 Roll Skia from f6a5c806294d to 1ccf2093cfa9 (2 revisions) (flutter/engine#39028) * f02a70492 Roll Fuchsia Mac SDK from rQtxqj3gePeR-nTLv... to HxpwvvbQdk54L6_8q... (flutter/engine#39075) * 42eec6280 [Impeller] uniform offsets account for size (flutter/engine#39077) * b6a348a82 Ability to disable browser context menu (flutter/engine#38682) * 1b51696eb Roll Skia from 1ccf2093cfa9 to 0328e12ab195 (59 revisions) (flutter/engine#39078) * d83a705ef [embedder] Fix getting vkGetInstanceProcAddr (flutter/engine#39051) * 973b01c40 Fix doc analyzer breakage (flutter/engine#39082) * 55e9eafab Roll Dart SDK from 107a1280a61f to d1a0e860679e (2 revisions) (flutter/engine#39084) * fa07c546c Roll Skia from 0328e12ab195 to 50d78376d30c (3 revisions) (flutter/engine#39086) * 17abf1a9e Roll Fuchsia Linux SDK from GLRbnjiO5SbZKX-Us... to dWbkAZchFHtZE9Wt_... (flutter/engine#39087) * 5c46d75f7 Roll Skia from 50d78376d30c to 90fda2e72314 (4 revisions) (flutter/engine#39089) * 5b4e331a6 Add mmap dependency to flutter_frontend_server (flutter/engine#39090) * 7f38d0d4f Migrate `@FfiNative` to `@Native` (flutter/engine#39034) * 71ee5f19b Remove superfluous words from comments (flutter/engine#39068)
Vulkan embedder was incorrectly querying vkGetInstanceProcAddr without the vk prefix. Tests would not catch this because embedder tests were assuming that get_instance_proc_address_callback is only ever called to obtain vkGetInstanceProcAddr, and so just returned that function unconditionally.
Fixes: flutter/flutter#118956
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].