Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Get the vulkan backend working again #39103

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Get the vulkan backend working again #39103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6e3ee5
Enable Vulkan to be developed on macOS host
iskakaushik Jan 24, 2023
5d50731
remove enabling macOS
iskakaushik Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion impeller/renderer/backend/vulkan/context_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ VKAPI_ATTR VkBool32 VKAPI_CALL DebugUtilsMessengerCallback(
const auto prefix = impeller::vk::to_string(
impeller::vk::DebugUtilsMessageSeverityFlagBitsEXT{severity});

// There isn't stable messageIdNumber for this validation failure.
if (strstr(pCallbackData->pMessageIdName,
"CoreValidation-Shader-OutputNotConsumed") != nullptr) {
return VK_FALSE;
}

FML_DCHECK(false) << prefix << "[" << pCallbackData->messageIdNumber << "]["
<< pCallbackData->pMessageIdName
<< "] : " << pCallbackData->pMessage;
Expand Down Expand Up @@ -596,7 +602,7 @@ PixelFormat ContextVK::GetColorAttachmentPixelFormat() const {
}

const BackendFeatures& ContextVK::GetBackendFeatures() const {
return kModernBackendFeatures;
return kLegacyBackendFeatures;
}

vk::Queue ContextVK::GetGraphicsQueue() const {
Expand Down
2 changes: 1 addition & 1 deletion impeller/renderer/backend/vulkan/swapchain_details_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ vk::PresentModeKHR SwapchainDetailsVK::PickPresentationMode() const {
}
}

VALIDATION_LOG << "Picking a sub-optimal presentation mode.";
FML_LOG(ERROR) << "Picking a sub-optimal presentation mode.";
// Vulkan spec dictates that FIFO is always available.
return vk::PresentModeKHR::eFifo;
}
Expand Down