Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Follow up to #39113 #39134

Closed
wants to merge 2 commits into from
Closed

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer requested a review from cbracken January 25, 2023 18:22
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jan 25, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer
Copy link
Member Author

Closing, as sadly doing this is not legal in dart.

@goderbauer goderbauer closed this Jan 25, 2023
@goderbauer goderbauer deleted the rpalceStringComp branch March 3, 2023 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant