Reland "Remove references to Observatory (#38919)" #39139

bkonyi · 2023-01-25T21:04:21Z

This reverts commit 5dd9454.

bkonyi · 2023-01-25T21:19:54Z

I reverted the changes to the public APIs and marked them as deprecated. I think I caught them all, but I'm not sure where the public API boundaries are, so please let me know if I missed any.

jmagman · 2023-01-25T22:36:36Z

What was breaking in the Flutter -> plugins roll? #39035

bkonyi · 2023-01-26T15:06:55Z

shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java

+   * @deprecated replaced by {@link #getVMServiceUri()}.
+   */
+  @Deprecated
+  @Nullable
  public static String getObservatoryUri() {


@jmagman renaming this method had broken the espresso plugin.

Interesting... https://github.com/flutter/plugins/blob/7686be7ecbe1cc049423715b5e2d897cb63a43c1/packages/espresso/android/src/main/java/androidx/test/espresso/flutter/action/FlutterViewAction.java#L108

vashworth · 2023-01-27T17:07:05Z

shell/platform/darwin/ios/framework/Source/FlutterDartVMServicePublisher.mm


  if (err != 0) {
-    FML_LOG(ERROR) << "Failed to register observatory port with mDNS with error " << err << ".";
+    FML_LOG(ERROR) << "Failed to register Dart VM Service port with mDNS with error " << err << ".";


Networking in iOS is a protected resource and therefore requires permissions, specifically NSBonjourServices. Without it, this will always error and show this error message to users.

In the Flutter tools, we add in NSBonjourServices to the Info.plist on build here:
https://github.com/flutter/flutter/blob/c31856bc48596d251ade554c33a09184e69185d9/packages/flutter_tools/bin/xcode_backend.dart#L247-L285

To avoid errors, the tool should be updated first to include the new _dartVmService._tcp (and also keep the original _dartobservatory._tcp).

This code is falling back to _dartobservatory._tcp with the legacyRegistrationType check below so I think it should still work. However, it shouldn't log any errors like this of or the iOS 14 one until both fail.

@vashworth's suggestion to add both to the tool first would also work.

Updated to only output the error message after both registration attempts have failed.

jmagman

Requesting changes to remove the error logs until both the _dartVmService._tcp AND _dartobservatory._tcp checks fail.

jmagman

LGTM
@vashworth were your concerns addressed?

jmagman · 2023-01-27T21:52:42Z

shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java

+   * @deprecated replaced by {@link #getVMServiceUri()}.
+   */
+  @Deprecated
+  @Nullable
  public static String getObservatoryUri() {


Interesting... https://github.com/flutter/plugins/blob/7686be7ecbe1cc049423715b5e2d897cb63a43c1/packages/espresso/android/src/main/java/androidx/test/espresso/flutter/action/FlutterViewAction.java#L108

vashworth · 2023-01-27T23:32:33Z

LGTM @vashworth were your concerns addressed?

Yup, LGTM too!

…lutter/engine#39139)

…/engine#39139) (#119546)

…flutter/engine#39139) (#119546) Commit: 92df6b4bc06516151c838666d302dd1e4f4a590e

…lutter/engine#39139) (flutter/flutter#119546)

* 472b887 0ec8e2802 Roll Fuchsia Mac SDK from 9y7C2oamTv6Py4JSC... to EAFnGijD0l5QxaPxF... (flutter/engine#39236) (flutter/flutter#119461) * 15cd00f a7bb0e410 Roll Fuchsia Linux SDK from 1D63BqURfJdG4r3CK... to xTXbcsPr5GJvFSLha... (flutter/engine#39238) (flutter/flutter#119482) * 530c3f2 [Re-land#2] Button padding M3 (flutter/flutter#119498) * 17eb2e8 Ability to disable the browser's context menu on web (flutter/flutter#118194) * df8ad3d roll packages (flutter/flutter#119370) * b68cebd roll packages (flutter/flutter#119530) * 59d80dc [Android] Add explicit exported tag to Linux_android flavors test (flutter/flutter#117542) * 458b298 Refactoring to use `ver` command instead of `systeminfo` (flutter/flutter#119304) * 54405bf fixes PointerEventConverter to handle malformed scrolling event (flutter/flutter#118124) * e69ea6d Support flipping mouse scrolling axes through modifier keys (flutter/flutter#115610) * 92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (flutter/engine#39139) (flutter/flutter#119546) * 7477d7a Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (flutter/flutter#119529) * 6c12e39 Introduce ParagraphBoundary subclass for text editing (flutter/flutter#116549) * b227df3 Hint text semantics to be excluded in a11y read out if hintText is not visible. (flutter/flutter#119198) * 18c7f8a Fix typo in --machine help text (flutter/flutter#119563) * 329f86a Make a few values non-nullable in cupertino (flutter/flutter#119478) * c4520bc b2efe0175 [web] Expose felt flag for building CanvasKit Chromium (flutter/engine#39201) (flutter/flutter#119567) * 8898f4f Marks Mac_android run_debug_test_android to be unflaky (flutter/flutter#117468) * 1f0b6fb Remove deprecated AppBar/SliverAppBar/AppBarTheme.textTheme member (flutter/flutter#119253) * edaeec8 Roll Flutter Engine from b2efe01754ef to 5011144c0b46 (3 revisions) (flutter/flutter#119578) * 865dc5c Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (flutter/flutter#119584) * 1148a2a Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (flutter/flutter#119359) * 2340902 Roll Flutter Engine from daa8eeb7fc0b to 77218818138f (3 revisions) (flutter/flutter#119586) * 65900b7 Remove deprecated AnimatedSize.vsync parameter (flutter/flutter#119186) * 5b6572f Add debug diagnostics to channels integration test (flutter/flutter#119579) * 504e565 Roll Flutter Engine from 77218818138f to 9448f2966c11 (3 revisions) (flutter/flutter#119592) * 7ba4406 Revert "[Re-land#2] Button padding M3 (#119498)" (flutter/flutter#119597) * 2c34a88 Roll Flutter Engine from 9448f2966c11 to 72abe0e4b828 (3 revisions) (flutter/flutter#119603) * df0ab40 Roll Plugins from ff84c44 to 9da327c (15 revisions) (flutter/flutter#119629) * 67d07a6 [flutter_tools] Fix parsing of existing DDS URIs from exceptions (flutter/flutter#119506) * d272a3a Reland: [macos] add flavor options to tool commands (flutter/flutter#119564) * a16d82c aa00da3c1 Roll Skia from fc31f43cc40a to 3c6eb76a683a (1 revision) (flutter/engine#39280) (flutter/flutter#119605) * f6b0c6d Use first Dart VM Service found with mDNS if there are duplicates (flutter/flutter#119545) * d4c7485 Make Decoration.padding non-nullable (flutter/flutter#119581) * 2fccf4d Remove MediaQuery from WidgetsApp (flutter/flutter#119377) * 9b3b9cf Roll Flutter Engine from aa00da3c1612 to cd2e8885e491 (6 revisions) (flutter/flutter#119639) * 6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195) * e2b3d89 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515) * 7bf95f4 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640) * 0e22aca Add support for image insertion on Android (flutter/flutter#110052) * ff22813 separatorBuilder can't return null (flutter/flutter#119566) * 60c1f29 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645) * fbe9ff3 Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653) * 8f90e2a Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655) * 3884381 Make gen-l10n error handling independent of logger state (flutter/flutter#119644) * 198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033) * dc86565 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670) * 82df235 Undo making Flex,Row,Column const (flutter/flutter#119669) * 6f9a896 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675) * 8d0af36 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595) * 3894d24 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683) * a752c2f Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439) * e1f0b1d d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686) * 97d273c CupertinoThemeData equality (flutter/flutter#119480) * 4167835 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688) * b4a6e34 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695) * 3af30ff Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706) * d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)

Reland "Remove references to Observatory (#38919)"

da2c3cd

This reverts commit 5dd9454.

flutter-dashboard bot added embedder Related to the embedder API platform-android platform-fuchsia platform-ios platform-web Code specifically for the web engine labels Jan 25, 2023

Add back original public APIs and mark them as deprecated

2115b08

bkonyi changed the title ~~[WIP] Reland "Remove references to Observatory (#38919)"~~ Reland "Remove references to Observatory (#38919)" Jan 25, 2023

bkonyi requested review from zanderso, jmagman and bparrishMines January 25, 2023 21:18

Add back additional public APIs

f4150b3

bkonyi commented Jan 26, 2023

View reviewed changes

vashworth reviewed Jan 27, 2023

View reviewed changes

jmagman suggested changes Jan 27, 2023

View reviewed changes

Addresss mDNS comments

5f0014f

jmagman approved these changes Jan 27, 2023

View reviewed changes

bkonyi merged commit 396c7fd into main Jan 30, 2023

bkonyi deleted the reland_observatory_messaging_removal branch January 30, 2023 14:50

engine-flutter-autoroll mentioned this pull request Jan 30, 2023

Roll Flutter Engine from a7bb0e410884 to 396c7fd0bd32 (1 revision) flutter/flutter#119520

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2023

396c7fd0b Reland "Remove references to Observatory (flutter#38919)" (f…

b50c6d7

…lutter/engine#39139)

engine-flutter-autoroll mentioned this pull request Jan 30, 2023

Roll Flutter Engine from a7bb0e410884 to 396c7fd0bd32 (1 revision) flutter/flutter#119546

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2023

396c7fd0b Reland "Remove references to Observatory (flutter#38919)" (f…

6b73e91

…lutter/engine#39139)

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 30, 2023

396c7fd0b Reland "Remove references to Observatory (#38919)" (flutter…

92df6b4

…/engine#39139) (#119546)

sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Jan 30, 2023

flutter: 396c7fd0b Reland "Remove references to Observatory (#38919)" (…

6e8084e

…flutter/engine#39139) (#119546) Commit: 92df6b4bc06516151c838666d302dd1e4f4a590e

engine-flutter-autoroll mentioned this pull request Jan 31, 2023

Roll Flutter from 27f8ebdaed70 to 2c34a88eb896 (51 revisions) flutter/packages#3120

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

d1d3856

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll mentioned this pull request Jan 31, 2023

Roll Flutter from 27f8ebdaed70 to 2c34a88eb896 (51 revisions) flutter/packages#3121

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

4abd936

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll mentioned this pull request Jan 31, 2023

Roll Flutter from 27f8ebdaed70 to df0ab40ecef8 (52 revisions) flutter/packages#3122

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

efd04bb

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll mentioned this pull request Jan 31, 2023

Roll Flutter from 27f8ebdaed70 to a16d82cbad40 (55 revisions) flutter/packages#3123

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

4d90b32

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll mentioned this pull request Jan 31, 2023

Roll Flutter from 27f8ebdaed70 to f6b0c6ddef40 (56 revisions) flutter/packages#3124

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

9e3d8c0

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll mentioned this pull request Jan 31, 2023

Roll Flutter from 27f8ebdaed70 to 2fccf4d47149 (58 revisions) flutter/packages#3125

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

a31be7a

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll mentioned this pull request Jan 31, 2023

Roll Flutter from 27f8ebdaed70 to 9b3b9cf0893d (59 revisions) flutter/packages#3126

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

a8aa856

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 0a22a1dbf475 to b4a6e349a25b (56 revisions) flutter/plugins#7075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

a06b689

…lutter/engine#39139) (flutter/flutter#119546)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023

92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (f…

6626b6c

…lutter/engine#39139) (flutter/flutter#119546)

vashworth mentioned this pull request May 15, 2023

Documentation needs to updated to new service name flutter/flutter#126838

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland "Remove references to Observatory (#38919)" #39139

Reland "Remove references to Observatory (#38919)" #39139

Uh oh!

bkonyi commented Jan 25, 2023

Uh oh!

bkonyi commented Jan 25, 2023

Uh oh!

jmagman commented Jan 25, 2023

Uh oh!

bkonyi Jan 26, 2023

Uh oh!

jmagman Jan 27, 2023

Uh oh!

vashworth Jan 27, 2023

Uh oh!

jmagman Jan 27, 2023

Uh oh!

bkonyi Jan 27, 2023

Uh oh!

jmagman left a comment

Uh oh!

jmagman left a comment

Uh oh!

jmagman Jan 27, 2023

Uh oh!

vashworth commented Jan 27, 2023

Uh oh!

Uh oh!

Reland "Remove references to Observatory (#38919)" #39139

Reland "Remove references to Observatory (#38919)" #39139

Uh oh!

Conversation

bkonyi commented Jan 25, 2023

Uh oh!

bkonyi commented Jan 25, 2023

Uh oh!

jmagman commented Jan 25, 2023

Uh oh!

bkonyi Jan 26, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

vashworth Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

bkonyi Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

vashworth commented Jan 27, 2023

Uh oh!

Uh oh!