This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Revert "[macos] Move TextInputPlugin outside of visible area" #39176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 789a549.
cbracken
approved these changes
Jan 26, 2023
Thanks. Relevant test failure:
|
I think this is because the PR was submitted and approved before #39145 landed and merged after. If I rebased this before merging it would have been caught. My bad. I'll make another PR to reland this with fixed test. |
Landing tip-of-tree revert without waiting for presubs to finish |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2023
…119299) * 789a549f4 [macos] Move TextInputPlugin outside of visible area (flutter/engine#39031) * e17f58747 Revert "[macos] Move TextInputPlugin outside of visible area (#39031)" (flutter/engine#39176) * a63d98feb Update buildroot to abada33. (flutter/engine#39173)
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39031
Seems responsible for the test failure on CI here: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/23111/overview