Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "[macos] Move TextInputPlugin outside of visible area" #39176

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

zanderso
Copy link
Member

@cbracken
Copy link
Member

cbracken commented Jan 26, 2023

Thanks. Relevant test failure:

[ RUN      ] FlutterTextInputPluginTest.CanWorkWithFlutterTextField
embedder.cc (2428): 'FlutterEngineUpdateSemanticsEnabled' returned 'kInvalidArguments'. Invalid engine handle.
embedder.cc (2237): 'FlutterEngineSendPlatformMessage' returned 'kInvalidArguments'. Invalid engine handle.
2023-01-26 13:33:35.043 flutter_desktop_darwin_unittests[56507:1401346] Failed to send message to Flutter engine on channel 'flutter/textinput' (2).
[       OK ] FlutterTextInputPluginTest.CanWorkWithFlutterTextField (112 ms)
[ RUN      ] FlutterTextInputPluginTest.HasZeroSize
2023-01-26 13:33:35.151 flutter_desktop_darwin_unittests[56507:1401346] *** Assertion failure in void CommonInit(FlutterViewController *__strong, FlutterEngine *__strong)(), FlutterViewController.mm:313
2023-01-26 13:33:35.157 flutter_desktop_darwin_unittests[56507:1401346] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'The FlutterViewController unexpectedly stays unattached after initialization. In unit tests, this is likely because either the FlutterViewController or the FlutterEngine is mocked. Please subclass these classes instead.'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007ff809ea8773 __exceptionPreprocess + 242
	1   libobjc.A.dylib                     0x00007ff809c08bc3 objc_exception_throw + 48
	2   Foundation                          0x00007ff80ad95a23 -[NSMutableDictionary(NSMutableDictionary) initWithContentsOfFile:] + 0
	3   flutter_desktop_darwin_unittests    0x000000010044226d _ZL10CommonInitP21FlutterViewControllerP13FlutterEngine + 733
	4   flutter_desktop_darwin_unittests    0x0000000100442642 -[FlutterViewController initWithEngine:nibName:bundle:] + 194
	5   flutter_desktop_darwin_unittests    0x00000001004020fd _ZN7flutter7testing43FlutterTextInputPluginTest_HasZeroSize_Test8TestBodyEv + 461
	6   flutter_desktop_darwin_unittests    0x000000010103bacc _ZN7testing4Test3RunEv + 220
	7   flutter_desktop_darwin_unittests    0x000000010103c785 _ZN7testing8TestInfo3RunEv + 277
	8   flutter_desktop_darwin_unittests    0x000000010103d495 _ZN7testing9TestSuite3RunEv + 517
	9   flutter_desktop_darwin_unittests    0x000000010104c02d _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 1117
	10  flutter_desktop_darwin_unittests    0x000000010104ba94 _ZN7testing8UnitTest3RunEv + 132
	11  flutter_desktop_darwin_unittests    0x000000010048e8df main + 303
	12  dyld                                0x000000010e6f852e start + 462
)
libc++abi: terminating with uncaught exception of type NSException
[ERROR:flutter/fml/backtrace.cc(108)] Caught signal SIGABRT during program execution.
Frame 0: 0x7ff809d22082 abort_message
Frame 1: 0x7ff809d131bd demangling_unexpected_handler()
Frame 2: 0x7ff809c0fe11 _objc_terminate()
Frame 3: 0x7ff809d214a7 std::__terminate()
Frame 4: 0x7ff809d23d05 __cxa_get_exception_ptr
Frame 5: 0x7ff809d23ccc __cxxabiv1::exception_cleanup_func()
Frame 6: 0x7ff809c08cc1 objc_exception_throw
Frame 7: 0x7ff80ad95a23 -[NSMutableDictionary(NSMutableDictionary) initWithContentsOfFile:]
Frame 8: 0x10044226d CommonInit()
Frame 9: 0x100442642 -[FlutterViewController initWithEngine:nibName:bundle:]
Frame 10: 0x1004020fd flutter::testing::FlutterTextInputPluginTest_HasZeroSize_Test::TestBody()
Frame 11: 0x10103bacc testing::Test::Run()
Frame 12: 0x10103c785 testing::TestInfo::Run()
Frame 13: 0x10103d495 testing::TestSuite::Run()
Frame 14: 0x10104c02d testing::internal::UnitTestImpl::RunAllTests()
Frame 15: 0x10104ba94 testing::UnitTest::Run()
Frame 16: 0x10048e8df main
Frame 17: 0x10e6f852e start

@knopp
Copy link
Member

knopp commented Jan 26, 2023

I think this is because the PR was submitted and approved before #39145 landed and merged after. If I rebased this before merging it would have been caught. My bad. I'll make another PR to reland this with fixed test.

@zanderso
Copy link
Member Author

Landing tip-of-tree revert without waiting for presubs to finish

@zanderso zanderso merged commit e17f587 into main Jan 26, 2023
@zanderso zanderso deleted the revert-39031-macos_hide_text_input_plugin branch January 26, 2023 21:48
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 27, 2023
…119299)

* 789a549f4 [macos] Move TextInputPlugin outside of visible area (flutter/engine#39031)

* e17f58747 Revert "[macos] Move TextInputPlugin outside of visible area (#39031)" (flutter/engine#39176)

* a63d98feb Update buildroot to abada33. (flutter/engine#39173)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants