Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] @JS('Intl') #39211

Merged
merged 4 commits into from
Jan 30, 2023
Merged

[web] @JS('Intl') #39211

merged 4 commits into from
Jan 30, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jan 27, 2023

Is this better, worse or same?

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jan 27, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

eyebrowsoffire
eyebrowsoffire approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2023

auto label is removed for flutter/engine, pr: 39211, due to - The status or check suite Linux Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit auto-submit bot merged commit e67a30e into flutter:main Jan 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
e67a30e00 [web] @js('Intl') (flutter/engine#39211)
0479614
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
Roll Flutter Engine from daa8eeb7fc0b to 77218818138f (3 revisions) (#…
2340902 
…119586)

* e67a30e00 [web] @js('Intl') (flutter/engine#39211)

* 7cb1f0ce7 [web] Use our own icu_bidi (flutter/engine#39200)

* 772188181 @alwaysThrows is deprecated. Return `Never` instead. (flutter/engine#39269)
@mdebbar mdebbar deleted the dom_intl branch June 22, 2023 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdebbar @eyebrowsoffire