Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Download emsdk for web framework tests. #39268

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

eyebrowsoffire
Copy link
Contributor

This is in preparation for changes that will use --local-web-sdk instead of --local-engine for the web framework tests.

This is in preparation for changes that will use `--local-web-sdk`
instead of `--local-engine` for the web framework tests.
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2023

auto label is removed for flutter/engine, pr: 39268, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 31, 2023

auto label is removed for flutter/engine, pr: 39268, due to - The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023
@auto-submit auto-submit bot merged commit b7f152d into flutter:main Jan 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 31, 2023
…119603)

* a80741c39 Roll Skia from 3c4cd77c5e5d to fc31f43cc40a (1 revision) (flutter/engine#39278)

* b7f152d50 Download emsdk for web framework tests. (flutter/engine#39268)

* 72abe0e4b Remove useless variable in Canvas.drawCircle. (flutter/engine#39250)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants