This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove uses of --full-dart-sdk from the engine_v2 builders.
#39297
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,102 +1,41 @@ | ||
| { | ||
| "builds": [ | ||
| { | ||
| "archives": [], | ||
| "drone_dimensions": [ | ||
| "device_type=none", | ||
| "os=Windows-10" | ||
| ], | ||
| "gn": [ | ||
| "--runtime-mode", | ||
| "debug", | ||
| "--unoptimized", | ||
| "--full-dart-sdk", | ||
| "--prebuilt-dart-sdk" | ||
| ], | ||
| "name": "windows_host_debug", | ||
| "ninja": { | ||
| "config": "host_debug_unopt", | ||
| "targets": [] | ||
| }, | ||
| "platform": "Windows", | ||
| "tests": [] | ||
| }, | ||
| { | ||
| "archives": [], | ||
| "drone_dimensions": [ | ||
| "device_type=none", | ||
| "os=Linux" | ||
| ], | ||
| "generators": { | ||
| "pub_dirs": [ | ||
| "flutter/lib/web_ui/", | ||
| "flutter/web_sdk/web_engine_tester/" | ||
| "generators": { | ||
| "pub_dirs": [ | ||
| "flutter/lib/web_ui/", | ||
| "flutter/web_sdk/web_engine_tester/" | ||
| ], | ||
| "tasks": [ | ||
| { | ||
| "name": "compile web_tests", | ||
| "parameters": [ | ||
| "run", | ||
| "compile_tests" | ||
| ], | ||
| "tasks": [ | ||
| { | ||
| "name": "compile web_tests", | ||
| "parameters": [ | ||
| "run", | ||
| "compile_tests" | ||
| ], | ||
| "scripts": [ | ||
| "out/host_debug_unopt/dart-sdk/bin/dart", | ||
| "flutter/lib/web_ui/dev/felt.dart" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "check licenses", | ||
| "parameters": [ | ||
| "check-licenses" | ||
| ], | ||
| "scripts": [ | ||
| "out/host_debug_unopt/dart-sdk/bin/dart", | ||
| "flutter/lib/web_ui/dev/felt.dart" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "web engine analysis", | ||
| "parameters": [], | ||
| "scripts": [ | ||
| "flutter/lib/web_ui/dev/web_engine_analysis.sh" | ||
| ] | ||
| } | ||
| "scripts": [ | ||
| "out/host_debug_unopt/dart-sdk/bin/dart", | ||
| "flutter/lib/web_ui/dev/felt.dart" | ||
| ] | ||
| }, | ||
| "gn": [ | ||
| "--runtime-mode", | ||
| "debug", | ||
| "--unoptimized", | ||
| "--full-dart-sdk" | ||
| ], | ||
| "name": "linux_host_debug_unopt", | ||
| "ninja": { | ||
| "config": "host_debug_unopt", | ||
| "targets": [] | ||
| }, | ||
| "platform": "Linux", | ||
| "tests": [] | ||
| }, | ||
| { | ||
| "archives": [], | ||
| "drone_dimensions": [ | ||
| "device_type=none", | ||
| "os=Mac" | ||
| ], | ||
| "gn": [ | ||
| "--runtime-mode", | ||
| "debug", | ||
| "--unoptimized", | ||
| "--full-dart-sdk", | ||
| "--prebuilt-dart-sdk" | ||
| ], | ||
| "name": "mac_host_debug_unopt", | ||
| "ninja": { | ||
| "config": "host_debug_unopt", | ||
| "targets": [] | ||
| { | ||
| "name": "check licenses", | ||
| "parameters": [ | ||
| "check-licenses" | ||
| ], | ||
| "scripts": [ | ||
| "out/host_debug_unopt/dart-sdk/bin/dart", | ||
| "flutter/lib/web_ui/dev/felt.dart" | ||
| ] | ||
| }, | ||
| "platform": "Mac", | ||
| "tests": [] | ||
| } | ||
| ] | ||
| { | ||
| "name": "web engine analysis", | ||
| "parameters": [ | ||
| "analyze" | ||
| ], | ||
| "scripts": [ | ||
| "out/host_debug_unopt/dart-sdk/bin/dart", | ||
| "flutter/lib/web_ui/dev/felt.dart" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we don't need this artifact anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. The flutter tool no longer uses any of the host specific flutter-web-sdk artifacts (i.e.
flutter-web-sdk-{platform-name}.zip). It now just usesflutter-web-sdk.zipwhich is host-agnostic, and that is produced by the linux_host_engine builder.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!