This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] dont append to existing atlas if type changed #39913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Feb 27, 2023
jonahwilliams
added
the
autosubmit
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Feb 27, 2023
[Impeller] dont append to existing atlas if type changed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2023
|
@jonahwilliams noticed this related to emojis They get colored black if background is white
They get color with the text color, if text is colored
No issue if background is back and text is white
No issue with Skia |
|
@delfme Could you file an issue please? Or did you bisect the issue to this change? |
|
Idk if this issue of "emojis being colored with the text color" is connected to last change, He fixed black colored emojis, so spent time around emojis and their color. If he has an idea about what this can be, I would be happy not to file an issue. The code is from a closed source and would take me time to create a demo. |
|
I noticed that the bug required a more detailed explanation, so I filed below issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#121128
If a new glyph fit into the old atlas but the type changed we incorrectly reused the old atlas. make sure it is recreated if the type changes