Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Use the new update semantics embedder API #40072

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[Windows] Use the new update semantics embedder API #40072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions shell/platform/windows/flutter_windows_engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,18 +327,19 @@ bool FlutterWindowsEngine::Run(std::string_view entrypoint) {
auto host = static_cast<FlutterWindowsEngine*>(user_data);
host->OnPreEngineRestart();
};
args.update_semantics_callback = [](const FlutterSemanticsUpdate* update,
void* user_data) {
args.update_semantics_callback2 = [](const FlutterSemanticsUpdate2* update,
void* user_data) {
auto host = static_cast<FlutterWindowsEngine*>(user_data);

for (size_t i = 0; i < update->nodes_count; i++) {
host->accessibility_bridge_->AddFlutterSemanticsNodeUpdate(
update->nodes[i]);
for (size_t i = 0; i < update->node_count; i++) {
const FlutterSemanticsNode2* node = update->nodes[i];
host->accessibility_bridge_->AddFlutterSemanticsNodeUpdate(*node);
}

for (size_t i = 0; i < update->custom_actions_count; i++) {
for (size_t i = 0; i < update->custom_action_count; i++) {
const FlutterSemanticsCustomAction2* action = update->custom_actions[i];
host->accessibility_bridge_->AddFlutterSemanticsCustomActionUpdate(
update->custom_actions[i]);
*action);
}

host->accessibility_bridge_->CommitUpdates();
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/windows/flutter_windows_engine_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ TEST_F(FlutterWindowsEngineTest, RunDoesExpectedInitialization) {
EXPECT_NE(args->custom_task_runners->thread_priority_setter, nullptr);
EXPECT_EQ(args->custom_dart_entrypoint, nullptr);
EXPECT_NE(args->vsync_callback, nullptr);
EXPECT_NE(args->update_semantics_callback, nullptr);
EXPECT_EQ(args->update_semantics_callback, nullptr);
EXPECT_NE(args->update_semantics_callback2, nullptr);
EXPECT_EQ(args->update_semantics_node_callback, nullptr);
EXPECT_EQ(args->update_semantics_custom_action_callback, nullptr);

Expand Down