This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate SVG to JS types #40401
Merged
Migrate SVG to JS types #40401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
@eyebrowsoffire ptal. @ditman, @mdebbar FYI, please feel free to review if you like. |
ditman
approved these changes
Mar 17, 2023
| @@ -10,7 +11,8 @@ import 'package:ui/src/engine.dart' as engine; | |||
| import 'package:ui/ui.dart' as ui; | |||
|
|
|||
| @JS('_flutter') | |||
| external set loader(Object? loader); | |||
| external set _loader(JSAny? loader); | |||
| set loader(Object? l) => _loader = l?.toJSAnyShallow; | |||
There was a problem hiding this comment.
Took me a while to figure out why this was a setter (it's a test 🤦)
There was a problem hiding this comment.
I may be misunderstanding something here, but isn't this redundant with the js_util.jsify(...) calls below?
set loader(Object? l) => _loader = l?.toJSAnyShallow;
// in tests:
loader = js_util.jsify(<String, Object>{
'loader': <String, Object>{
'didCreateEngineInitializer': allowInterop(() { print('not mocked'); }),
},
});There was a problem hiding this comment.
Ahh yea, good catch, it is redundant. I'm not actually trying to investigate usage patterns too deeply at this phase of the migration, mostly to derisk the conversion. That said, this is a good candidate for cleanup when we try to push JS types deeper into the Web engine. Thankfully this is a test, and jsify now has fast paths for types it doesn't need to convert.
eyebrowsoffire
approved these changes
Mar 20, 2023
joshualitt
force-pushed
the
2-js-types
branch
3 times, most recently
from
ef4ac03 to
2943832
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 22, 2023
Roll Flutter Engine from bb51cda2fa47 to 5775c6b05fa4 (1 revision)
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 22, 2023
…23217) Commit: b42e8db6cf8f7aa0e8debb7dec423b9080d3727f
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
This was referenced Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
This was referenced Mar 28, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.