This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add validation for mipmap generation enforced at binding time #40515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 23, 2023
… binding time (flutter/engine#40515) (#123300) Roll Flutter Engine from 02171d1f836c to 3f9fe923b037 (1 revision)
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 23, 2023
…forced at binding time (flutter/engine#40515) (#123300) Commit: c3934573b332641e7bed1cc7aa58f92a82e574ec
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
…orced at binding time (flutter/engine#40515) (flutter/flutter#123300)
This was referenced Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
…orced at binding time (flutter/engine#40515) (flutter/flutter#123300)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
…orced at binding time (flutter/engine#40515) (flutter/flutter#123300)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
…orced at binding time (flutter/engine#40515) (flutter/flutter#123300)
This was referenced Mar 28, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…orced at binding time (flutter/engine#40515) (flutter/flutter#123300)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…orced at binding time (flutter/engine#40515) (flutter/flutter#123300)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sampling from textures with a mip count > 1 but with no mipmaps generated is not defined by the GLES 2 spec, and drivers may either sample all zeroes in this case or other random data in the heap.
We've already run into a bug caused by not generating mipmaps. This change makes such mistakes easy to catch and prevents unsafe reading of garbage data.