This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[macOS]Support SemanticsService.announce #40585
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4f616a4
Update FlutterEngine.mm
hannah-hyj 5f821a5
Update FlutterEngine.mm
hannah-hyj b4cd5f6
Update shell/platform/darwin/macos/framework/Source/FlutterEngine.mm
hannah-hyj 51e4da3
test
hannah-hyj 066d786
Update FlutterEngineTest.mm
hannah-hyj 6e03638
Update FlutterEngine.mm
hannah-hyj 4a08350
Update FlutterEngineTest.mm
hannah-hyj cf191c8
Update FlutterEngineTest.mm
hannah-hyj 1b4f3dd
Update FlutterEngine.mm
hannah-hyj f1b9b13
Update FlutterEngine.mm
hannah-hyj fb8fe4b
update
hannah-hyj c94863d
update tests
hannah-hyj 6cc1494
Update FlutterEngineTest.mm
hannah-hyj 3ff6ee5
test
hannah-hyj 4d6ed39
lint
hannah-hyj 7a114d8
Update FlutterEngineTest.mm
hannah-hyj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this crash if
data
,message
, orassertiveness
properties are missing? A malformed message should be ignored, though an error can be logged.(Asking as there was a recent crash on Windows embedder due to the framework sending unexpected clipboard messages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will result in
nil
, so the current code handles the cases where any/all of these are missing.To add a bit of detail:
assertiveness
we set the default priority; since messages to nil evaluate to nil, the ternary evaluates toNSAccessibilityPriorityMedium
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK perfect! :)