This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Handle cases where the max swapchain image count can be zero. #40776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec says "A value of 0 means that there is no limit on the number of images" and the Radeon driver on linux seems to do this and hang the swapchain.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
approved these changes
Mar 30, 2023
chinmaygarde
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2023
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 30, 2023
…age count can be zero. (flutter/engine#40776) (#123758) Commit: 843f37370ba6aab67fc31f2a101f414dccfe20fa
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 30, 2023
… can be zero. (flutter/engine#40776) (#123758) Roll Flutter Engine from 4bc5ca58d86a to 14e536b8c29c (1 revision)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
… can be zero. (flutter/engine#40776) (flutter#123758) Roll Flutter Engine from 4bc5ca58d86a to 14e536b8c29c (1 revision)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…ge count can be zero. (flutter/engine#40776) (flutter/flutter#123758)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says "A value of 0 means that there is no limit on the number of images" and the Radeon driver on linux seems to do this and hang the swapchain.