This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[a11y] Improve EmbedderA11yTest, fixture comments #40995
Merged
cbracken
merged 1 commit into
flutter:main
from
cbracken:embedder-a11y-unittest-breadcrumbs
Apr 8, 2023
Merged
[a11y] Improve EmbedderA11yTest, fixture comments #40995
cbracken
merged 1 commit into
flutter:main
from
cbracken:embedder-a11y-unittest-breadcrumbs
Apr 8, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86e8893
to
afe954d
Compare
This is stacked on top of #40993 the relevant diffs are in the second commit in this PR. |
afe954d
to
5cf8df7
Compare
loic-sharma
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! 🏆
a4e5336
to
22152af
Compare
loic-sharma
reviewed
Apr 7, 2023
603f6a7
to
c29057a
Compare
Alright I've reverted back to just cleaning up the comments as it was originally. I'll move the other refactoring to another patch. |
Add breadcrumbs to make it easier to jump between the Dart fixture side and the embedder side of the EmbedderA11yTest unit test.
c29057a
to
fe16f78
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2023
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
Add breadcrumbs to make it easier to jump between the Dart fixture side and the embedder side of the EmbedderA11yTest unit test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies cleanup/simplification to EmbedderA11yTest unit tests.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.