This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland [iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. #41022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Reland LGTM 👍
Also tagging @cyanglaz @jmagman @hellohuanlin who reviewed the reverted PR #40703.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2023
…Responder to ensure framework focus state is correct. (flutter/engine#41022)
3 tasks
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
…to ensure framework focus state is correct. (flutter#41022) Correct focus behavior when the keyboard is closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reland the PR that has been reverted because the framework side is not ready at that time.
Now we have merge the pr to let framework behave as expected.
So just reland this.
The code is identical with the original PR