This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove glyph pixel rounding during text frame conversion #41285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
force-pushed
the
bdero/text-once-more
branch
from
413bd75 to
ec51b4d
Compare
|
auto label is removed for flutter/engine, pr: 41285, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2023
…125039) flutter/engine@c4396f9...d297361 2023-04-18 [email protected] [macOS] Fix Ctrl+Tab is broken (flutter/engine#40706) 2023-04-18 [email protected] Roll Fuchsia Mac SDK from K1LGtKXyxRlW3Q9O1... to qZHSvkpAU1-YYGvYc... (flutter/engine#41293) 2023-04-18 [email protected] Roll buildroot to 059d155b4d452efd9c4427c45cddfd9445144869 (flutter/engine#41288) 2023-04-18 [email protected] [Impeller] Remove glyph pixel rounding during text frame conversion (flutter/engine#41285) 2023-04-18 [email protected] Revert "Reland "Migrate mac_host_engine to engine v2 builds."" (flutter/engine#41284) 2023-04-17 [email protected] focus SkiaGPUObject wrappers on only those objects that need the protection (flutter/engine#41237) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from K1LGtKXyxRlW to qZHSvkpAU1-Y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Apr 18, 2023
…lutter#41285) (cherry picked from commit b955dc5)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tale of glyph alignment problems:
..and so we can just get rid of this early rounding now.
Before:
After:
All of the glyphs in a text frame still snap together:
Screen.Recording.2023-04-17.at.6.43.29.PM.mov